Remove old __capability workaround #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichardson
commented
Jul 6, 2023
We are not diagnosing legacy placement for typedefs and there are some cases that don't seem quite right.
|
That's not a deprecated use, that's currently regarded as legitimate. |
arichardson
force-pushed
the
remove-old-__capability-workaround
branch
from
355e51f
to
de4fffe
Compare
|
Turns this can instead just be a NFCI diff reduction. |
jrtc27
reviewed
Jul 6, 2023
arichardson
force-pushed
the
remove-old-__capability-workaround
branch
2 times, most recently
from
5048dd3
to
af3be58
Compare
This exposed a new crash: CTSRD-CHERI#710
This workaround is no longer needed now that various bugs with __capability have been fixed. This reverts commit ce9e791
arichardson
force-pushed
the
remove-old-__capability-workaround
branch
from
af3be58
to
54f6448
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workaround is no longer needed now that various bugs with __capability
have been fixed. It does however change the legacy placement semantics for
some typedefs as the __capability qualifier is pushed to the outermost
scope instead of the typedef itself, so for:
the type of
foois nowstruct s **__capabilityinstead of the previousstruct s *__capability *.This reverts commit ce9e791