Partially fix info frame for purecap RISC-V
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsdjhb
reviewed
Jul 14, 2021
I don't remember exactly why the first diff is needed, but after fixing the frame bits |
Previously it would print: ``` (gdb) info fram Stack level 5, frame at 0x3fffdfb770: pcc = 0x42294b32 in QV4::Scoped<QV4::Object>::Scoped(QV4::Scope const&, QV4::Value const*); saved pcc = 0x4229b4c4 called by frame at 0x3fffdfb990, caller of frame at 0x3fffdfb6f0 Arglist at 0x3fffdfb770, args: Locals at 0x3fffdfb770,That operation is not available on integers of more than 8 bytes. ``` by using `extract_typed_address`, I get the following: ``` (gdb) info frame Stack level 5, frame at 0x3fffdfb770: pcc = 0x42294b32 in QV4::Scoped<QV4::Object>::Scoped(QV4::Scope const&, QV4::Value const*); saved pcc = 0x4229b4c4 called by frame at 0x3fffdfb990, caller of frame at 0x3fffdfb6f0 Arglist at 0x3fffdfb770, args: Locals at 0x3fffdfb770, Previous frame's sp is 0x3fffdfb770 Saved registers: cra at 0x3fffdfb760, cfp at 0x3fffdfb750, pcc at 0x3fffdfb760 ```
This ends up being called by `info frame` after the last commit and triggers an assertion inside riscv_is_regnum_a_named_csr().
arichardson
force-pushed
the
fix-info-frame
branch
from
821a241
to
0d14866
Compare
bsdjhb
approved these changes
Jul 23, 2021
| @@ -985,6 +985,8 @@ riscv_register_reggroup_p (struct gdbarch *gdbarch, int regnum, | |||
| { | |||
| if (regnum < RISCV_FIRST_CSR_REGNUM || regnum == RISCV_PRIV_REGNUM) | |||
| return 1; | |||
| if (regnum >= RISCV_FIRST_CHERI_REGNUM && regnum <= RISCV_LAST_CHERI_REGNUM) | |||
There was a problem hiding this comment.
I do wonder if the better fix is actually for the first 'if' here to be:
if (regnum < RISCV_FIRST_CSR_REGNUM || regnum > RISCV_LAST_CSR_REGNUM)
return 1;
That is something I could upstream, or perhaps even:
if (regnum >= RISCV_FIRST_CSR_REGNUM && regnum <= RISCV_LAST_CSR_REGNUM)
return riscv_is_regnum_a_named_csr (regnum);
return 1;
There was a problem hiding this comment.
This function is quite different upstream, so you can fix this however for now. Your existing patch is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it would print:
by using
extract_typed_address, I get the following: