SysV IPC: reduce diff around obsolete syscalls #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsdjhb
approved these changes
Aug 6, 2024
brooksdavis
force-pushed
the
ipcsys-reduce-diff
branch
from
e6a0dd7
to
d19a0ec
Compare
bsdjhb
reviewed
Aug 9, 2024
Restore the use of int as the argument for these extremely obsolete syscalls. It would arguably be more accurate to use syscallarg_t, but in practice it doesn't matter. First, because these are x86 only and really only used on practice on ancient i386 binaries and second, because of the way they are dispatched to the real sys_ syscall implementations. The only thing that might matter is the number of arguments.
brooksdavis
force-pushed
the
ipcsys-reduce-diff
branch
from
d19a0ec
to
b145632
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates most of the regen diff in #2167. I'm trying to kill these off most of the way in FreeBSD.