Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend #9

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Frontend #9

wants to merge 23 commits into from

Conversation

Tianwei-Qing
Copy link
Contributor

Migrate the changes from react-version app to google-extension-version app.
Main changes:

  1. add the fetch pull request in the popup.js file.
  2. add useState components in the popup.js file.
  3. add onChange effect in the inputTextBox.js and outputTextBox.js files in order to remember user input and output results sent back from PULL requests.

@Tianwei-Qing Tianwei-Qing self-assigned this Apr 5, 2023
@Tianwei-Qing Tianwei-Qing marked this pull request as draft April 5, 2023 17:15
@gitguardian
Copy link

gitguardian bot commented Apr 5, 2023

⚠️ GitGuardian has uncovered 9 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
6073288 Django Secret Key 532e01f backend/MultiLangTextSumGoogleExtension/MultiLangProject/settings.py View secret
6073288 Django Secret Key 1e32f2e backend/MultiLangTextSumGoogleExtension/MultiLangProject/settings.py View secret
6073289 Django Secret Key 1e32f2e backend/MultiLangTextSumGoogleExtension/MultiLangProject/settings.py View secret
6246695 Generic High Entropy Secret 252fcd5 backend/MultiLangProject/MultiLangApp/views.py View secret
6246695 Generic High Entropy Secret 1cee175 backend/MultiLangProject/MultiLangApp/views.py View secret
6246695 Generic High Entropy Secret 420547f backend/MultiLangProject/MultiLangApp/unittests.py View secret
6246695 Generic High Entropy Secret 420547f backend/MultiLangProject/MultiLangApp/unittests.py View secret
6246695 Generic High Entropy Secret 420547f backend/MultiLangProject/MultiLangApp/views.py View secret
6246695 Generic High Entropy Secret f522217 backend/MultiLangProject/MultiLangApp/views.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link
Contributor

@dingnan2 dingnan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great structure

@dingnan2 dingnan2 marked this pull request as ready for review April 5, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants