Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to separate bash and python scripts. #26

Closed
wants to merge 1 commit into from

Conversation

aidanheerdegen
Copy link
Contributor

Use parallel to allow simultaneous indexing and shuffling inputs.

Set file chunks to 1000.

Only here for information purposes in case it is useful. Requires update to COSIMA Cookbook

Use parallel to allow simultaneous indexing and shuffling inputs.

Set file chunks to 1000.
@aidanheerdegen aidanheerdegen marked this pull request as draft June 16, 2022 06:17
@aidanheerdegen
Copy link
Contributor Author

aidanheerdegen commented Jun 16, 2022

This refactor generated a list of experiment directories to index, and then used parallel to run a separate python updating script. As the idea of parallel execution is probably not going to work it is perhaps not that useful, but I think the general idea is good, as it is then easier to replace the bash script with some other way of supplying these experiment directories, like a yaml file for instance.

@micaeljtoliveira
Copy link
Contributor

@aidanheerdegen I think these changes are great, but I would go even further and move the python scrip to the COSIMA cookbook. That way we can ensure that the script is up-to-date with the database API. If you agree, I can take care of creating a PR for that.

@aidanheerdegen
Copy link
Contributor Author

aidanheerdegen commented Jun 29, 2022

Yes, agreed. I think a proper CLI tool, with some options and, say, a config.yaml file would be great. I'd suggest creating an Issue first, where we can dump some ideas/suggestions and discuss them before writing the code.

@aidanheerdegen
Copy link
Contributor Author

See COSIMA/cosima-cookbook#299 (would not have to be this complex in the first instance)

@micaeljtoliveira
Copy link
Contributor

I'm closing this PR, as this has been implemented in COSIMA/cosima-cookbook#300 and #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants