yanglint REFACTOR redundant code #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
michalvasko
reviewed
Jun 20, 2023
The yanglint options were stored in non-interactive mode in the structure named 'context'. This structure was renamed to yl_opt and is now also used in the interactive mode, which has also been expanded with new callbacks. These callbacks are the basis for further refactoring commits, which aim to reduce duplicate code between interactive and non-interactive modes to a minimum.
... because it is not necessary, libyang will take care of it.
lePici
force-pushed
the
devel
branch
2 times, most recently
from
e8810b9
to
51dc170
Compare
Now they shouldn't be skipping anymore.
michalvasko
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal was to reduce code redundancy between the interactive and non-interactive modes of yanglint. Also, this PR contains a bugfix for the long run of interactive tests.