Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Experian links #8125

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Update Experian links #8125

merged 1 commit into from
Sep 18, 2024

Conversation

emyl3
Copy link
Collaborator

@emyl3 emyl3 commented Sep 17, 2024 •
edited
Loading

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

Additional Information

  • N/A

Testing

Screenshots / Demos

  • N/A

@emyl3 emyl3 marked this pull request as ready for review September 17, 2024 20:42
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mehansen
mehansen approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@mehansen mehansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching!

bobbywells52
bobbywells52 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@bobbywells52 bobbywells52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both links are working -- LGTM

@emyl3
Copy link
Collaborator Author

emyl3 commented Sep 18, 2024

There are no UI changes but I accepted the UI changes discussed here to resolve the issue with changes in chromatic

@emyl3 emyl3 added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit ad1df86 Sep 18, 2024
37 checks passed
@emyl3 emyl3 deleted the elisa/7892-experian-link branch September 18, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehansen mehansen mehansen approved these changes

@DanielSass DanielSass DanielSass approved these changes

@bobbywells52 bobbywells52 bobbywells52 approved these changes

@mpbrown mpbrown Awaiting requested review from mpbrown

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

external link to Experian goes to a page that is 404
4 participants
@emyl3 @mehansen @DanielSass @bobbywells52