Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add constants module in lib_ccxr #1624

Conversation

IshanGrover2004
Copy link
Contributor

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Closes #1555

This PR adds some common enums & constants which will be used througjout the codebase. This PR code is equivalent to ccx_common_constants C file.

NOTE: Most of these enums are completely unrelated to each other and the only reason they are kept together for now is because they were kept together in C codebase. In the future when appropriate modules will be built, each of them will have to tranfered to their respective meaningful modules.

@PunitLodha
Copy link
Member

@IshanGrover2004 can you resolve the conflict

@IshanGrover2004 IshanGrover2004 force-pushed the migration-common-constants-module branch from 3e1e836 to aa9cca9 Compare July 16, 2024 16:00
@IshanGrover2004
Copy link
Contributor Author

IshanGrover2004 commented Jul 16, 2024

@IshanGrover2004 can you resolve the conflict

@PunitLodha Done for this PR

@PunitLodha PunitLodha merged commit cf9c9dd into CCExtractor:master Jul 16, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants