Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add time units module in lib_ccxr #1623

Merged

Conversation

IshanGrover2004
Copy link
Contributor

@IshanGrover2004 IshanGrover2004 commented Jul 8, 2024

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Closes #1556

This PR adds types that enables to store time in different representations like simple milliseconds, number of frames, etc. And also allow to interconvert between them. It also provides functions for formatting time in different kinds of formats. Certain functions are integrated into C codebase.

In comparision with PR #1556, I initiated lib_ccxr/utils/time.rs for only functions mentioned in utility.c & lib_ccxr/time/units.rs for necessary implementation(struct, enums, functions) of any work related to timings.
This lib_ccxr/time will be continued later as well for more timings code coversion

@ccextractor-bot

This comment has been minimized.

@PunitLodha
Copy link
Member

@IshanGrover2004 more conflicts here

@IshanGrover2004
Copy link
Contributor Author

@IshanGrover2004 more conflicts here

Done @PunitLodha

@PunitLodha PunitLodha merged commit 8d9bf42 into CCExtractor:master Jul 16, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants