[rust] add parser #1619
Merged
[rust] add parser #1619
+6,114
−1,072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
PunitLodha
approved these changes
Aug 2, 2024
.github/workflows/build_mac.yml
Outdated
Comment on lines
77
to
97
| # cmake_ocr_hardsubx: | ||
| # runs-on: macos-latest | ||
| # env: | ||
| # PKG_CONFIG_PATH: /opt/homebrew/opt/ffmpeg@6/lib/pkgconfig:$PKG_CONFIG_PATH | ||
| # FFMPEG_PKG_CONFIG_PATH: /opt/homebrew/opt/ffmpeg@6/lib/pkgconfig | ||
| # FFMPEG_INCLUDE_DIR: /opt/homebrew/opt/ffmpeg@6/include | ||
| # FFMPEG_LIBS_DIR: /opt/homebrew/opt/ffmpeg@6/lib | ||
| # steps: | ||
| # - uses: actions/checkout@v4 | ||
| # - name: Install dependencies | ||
| # run: brew install coreutils pkg-config autoconf automake libtool tesseract leptonica gpac ffmpeg@6 | ||
| # - name: cmake | ||
| # run: | | ||
| # mkdir build && cd build | ||
| # cmake -DWITH_OCR=ON -DWITH_HARDSUBX=ON ../src | ||
| # - name: build | ||
| # run: | | ||
| # make -j$(nproc) | ||
| # working-directory: build | ||
| # - name: Display version information | ||
| # run: ./build/ccextractor --version |
There was a problem hiding this comment.
Shouldn't this be uncommented?
.github/workflows/test_rust.yml
Outdated
| with: | ||
| toolchain: stable | ||
| override: true | ||
| - name: rustfmt |
| @@ -6,5 +6,5 @@ cd ..\..\windows | |||
| IF "%~1"=="-r" ( | |||
| copy x86_64-pc-windows-msvc\release\ccx_rust.lib .\ccx_rust.lib | |||
| ) ELSE ( | |||
| copy x86_64-pc-windows-msvc\debug\ccx_rust.lib .\ccx_rust.lib | |||
| copy x86_64-pc-windows-msvc\release-with-debug\ccx_rust.lib .\ccx_rust.lib | |||
There was a problem hiding this comment.
Why do we have release with debug here?
Comment on lines
+38
to
+40
| [profile.release-with-debug] | ||
| inherits = "release" | ||
| debug = true |
|
@prateekmedia also fix the merge conflicts |
10 tasks
|
@PunitLodha Done! |
|
@prateekmedia could you take a look at why the CI is failing |
|
@PunitLodha Done! |
PunitLodha
approved these changes
Aug 10, 2024
|
@prateekmedia @PunitLodha Are the sample test ran on this PR, Because I tested some samples on current CCExtractor code & its crashes which was working fine before this merging happens (I checked on each commit through when it is failing, found out this is the one which causes). |
|
@IshanGrover2004 The teletext PR will resolve the crashes currently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Rewrote argument parsing with all the structs and enums too into rust.
Help arguments demo:
Closed old PR as sample platform broke for it: #1547