-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(personaliztion-utils): Add A/B Test Trimming Support to trimHtml Function #3575
base: main
Are you sure you want to change the base?
Conversation
|
awesome! I wonder if we should also return an object so if we want to return more stuff in the future its easier. e.g. const { html } = trimHtml({ userAttributes: { ... } }) e.g. if we want to setup something that auto dice rolls for a/b tests that you aren't assigned to yet, we ideally want to make sure you set that as a cookie, so we could always return like const { html, newCookies } = ... if we wanted. maybe this is already accounted for, but just an idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when I read trimHtml
I think of a utility that trims excess whitespace.
Could we name it personalizeHTML
or something like that, which more explicitly describes that it's going to process/handle personalization?
Open to names, but this isn't specific to personalization. It handles scheduling, ab testing, and potentially more in future
…On Wed, Sep 25, 2024 at 11:45 AM, Sami Jaber < ***@***.*** > wrote:
***@***.**** commented on this pull request.
when I read trimHtml I think of a utility that trims excess whitespace.
Could we name it personalizeHTML or something like that, which more
explicitly describes that it's going to process/handle personalization?
—
Reply to this email directly, view it on GitHub (
#3575 (review)
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AAGOEA5EXOK72ORTC4KVYXTZYMAGDAVCNFSM6AAAAABO2GQJI6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMRZGIYDQOJQGE
).
You are receiving this because you commented. Message ID: <BuilderIO/builder/pull/3575/review/2329208901
@ github. com>
|
This PR extends the
trimHtml
function to support trimming A/B test variants in addition to personalization containers.Changes:
trimHtml
function to process A/B test variants before personalization containersabTests
parameter totrimHtml
optionsabTests
object