Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(personaliztion-utils): Add A/B Test Trimming Support to trimHtml Function #3575

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

teleaziz
Copy link
Collaborator

This PR extends the trimHtml function to support trimming A/B test variants in addition to personalization containers.

Changes:

  • Updated trimHtml function to process A/B test variants before personalization containers
  • Added abTests parameter to trimHtml options
  • Implemented logic to select winning A/B test variants based on provided abTests object
  • Updated README with information on A/B test trimming and usage examples

@teleaziz teleaziz requested a review from a team as a code owner September 25, 2024 10:26
@teleaziz teleaziz requested review from mrkoreye and removed request for a team September 25, 2024 10:26
Copy link

changeset-bot bot commented Sep 25, 2024

⚠️ No Changeset found

Latest commit: d1c939a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@steve8708
Copy link
Contributor

awesome! I wonder if we should also return an object so if we want to return more stuff in the future its easier. e.g.

const { html } = trimHtml({ userAttributes: { ... } })

e.g. if we want to setup something that auto dice rolls for a/b tests that you aren't assigned to yet, we ideally want to make sure you set that as a cookie, so we could always return like

const { html, newCookies } = ...

if we wanted. maybe this is already accounted for, but just an idea

Copy link
Contributor

@samijaber samijaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I read trimHtml I think of a utility that trims excess whitespace.

Could we name it personalizeHTML or something like that, which more explicitly describes that it's going to process/handle personalization?

@steve8708
Copy link
Contributor

steve8708 commented Sep 25, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants