-
Notifications
You must be signed in to change notification settings - Fork 911
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix[gen2-sdks]: repeat symbols with bound content input data (#3541)
## Description Symbol has `noWrap: true` and we were not handling repeat items when a block had `noWrap`, this PR fixes it **Jira** https://builder-io.atlassian.net/browse/ENG-6658 _Screenshot_ If relevant, add a screenshot or two of the changes you made.
- Loading branch information
1 parent
ba8447b
commit 51285ea
Showing
8 changed files
with
295 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| --- | ||
| "@builder.io/sdk-angular": patch | ||
| "@builder.io/sdk-react-nextjs": patch | ||
| "@builder.io/sdk-qwik": patch | ||
| "@builder.io/sdk-react": patch | ||
| "@builder.io/sdk-react-native": patch | ||
| "@builder.io/sdk-solid": patch | ||
| "@builder.io/sdk-svelte": patch | ||
| "@builder.io/sdk-vue": patch | ||
| --- | ||
|
|
||
| Fix: repeat items when they are Symbols |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
224 changes: 224 additions & 0 deletions
224
packages/sdks-tests/src/specs/symbol-with-repeat-input-binding.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,224 @@ | ||
| export const SYMBOL_WITH_REPEAT_INPUT_BINDING = { | ||
| ownerId: 'ad30f9a246614faaa6a03374f83554c9', | ||
| lastUpdateBy: null, | ||
| createdDate: 1725872832969, | ||
| id: '3413ca2078c24216be71bacf54adbfc9', | ||
| '@version': 4, | ||
| name: 'data-symbols', | ||
| modelId: '17c6065109ef4062ba083f5741f4ee6a', | ||
| published: 'published', | ||
| meta: { | ||
| symbolsUsed: { | ||
| f8f9e85ab8504e7db68c1d896d652c91: true, | ||
| }, | ||
| kind: 'page', | ||
| hasLinks: false, | ||
| lastPreviewUrl: | ||
| 'http://localhost:5173/data-symbols?builder.space=ad30f9a246614faaa6a03374f83554c9&builder.user.permissions=read%2Ccreate%2Cpublish%2CeditCode%2CeditDesigns%2Cadmin%2CeditLayouts%2CeditLayers&builder.user.role.name=Admin&builder.user.role.id=admin&builder.cachebust=true&builder.preview=page&builder.noCache=true&builder.allowTextEdit=true&__builder_editing__=true&builder.overrides.page=3413ca2078c24216be71bacf54adbfc9&builder.overrides.3413ca2078c24216be71bacf54adbfc9=3413ca2078c24216be71bacf54adbfc9&builder.overrides.page:/data-symbols=3413ca2078c24216be71bacf54adbfc9&builder.options.locale=Default', | ||
| }, | ||
| priority: -647, | ||
| stage: 'b3ee01559a244a078973f545ad475eba', | ||
| query: [ | ||
| { | ||
| '@type': '@builder.io/core:Query', | ||
| property: 'urlPath', | ||
| operator: 'is', | ||
| value: '/data-symbols', | ||
| }, | ||
| ], | ||
| data: { | ||
| themeId: false, | ||
| inputs: [], | ||
| title: 'data-symbols', | ||
| blocks: [ | ||
| { | ||
| '@type': '@builder.io/sdk:Element', | ||
| '@version': 2, | ||
| bindings: { | ||
| 'component.options.symbol.data.header': | ||
| 'var _virtual_index=state.productsItem.header;return _virtual_index', | ||
| }, | ||
| code: { | ||
| bindings: { | ||
| 'component.options.symbol.data.header': 'state.productsItem.header', | ||
| }, | ||
| }, | ||
| repeat: { | ||
| collection: 'state.products', | ||
| }, | ||
| id: 'builder-c4c338558fb747068e63cd6b97f037ba', | ||
| meta: { | ||
| bindingActions: { | ||
| component: { | ||
| options: { | ||
| symbol: { | ||
| data: { | ||
| header: null, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| component: { | ||
| name: 'Symbol', | ||
| options: { | ||
| dataOnly: false, | ||
| inheritState: false, | ||
| renderToLiquid: false, | ||
| symbol: { | ||
| model: 'symbol', | ||
| entry: 'f8f9e85ab8504e7db68c1d896d652c91', | ||
| data: { | ||
| header: 'nothing', | ||
| }, | ||
| ownerId: 'ad30f9a246614faaa6a03374f83554c9', | ||
| content: { | ||
| ownerId: 'ad30f9a246614faaa6a03374f83554c9', | ||
| lastUpdateBy: null, | ||
| createdDate: 1725873478428, | ||
| id: 'f8f9e85ab8504e7db68c1d896d652c91', | ||
| '@version': 4, | ||
| name: 'data-symbol-symbol', | ||
| modelId: '5e1209efea0045f58d9b871d81b652fa', | ||
| published: 'published', | ||
| meta: { | ||
| hasLinks: false, | ||
| kind: 'component', | ||
| lastPreviewUrl: | ||
| 'https://preview.builder.codes?model=symbol&previewing=true&apiKey=ad30f9a246614faaa6a03374f83554c9&builder.space=ad30f9a246614faaa6a03374f83554c9&builder.user.permissions=read%2Ccreate%2Cpublish%2CeditCode%2CeditDesigns%2Cadmin%2CeditLayouts%2CeditLayers&builder.user.role.name=Admin&builder.user.role.id=admin&builder.cachebust=true&builder.preview=symbol&builder.noCache=true&builder.allowTextEdit=true&__builder_editing__=true&builder.overrides.symbol=f8f9e85ab8504e7db68c1d896d652c91&builder.overrides.f8f9e85ab8504e7db68c1d896d652c91=f8f9e85ab8504e7db68c1d896d652c91&builder.options.locale=Default', | ||
| }, | ||
| priority: -652, | ||
| stage: 'b3ee01559a244a078973f545ad475eba', | ||
| query: [], | ||
| data: { | ||
| inputs: [ | ||
| { | ||
| '@type': '@builder.io/core:Field', | ||
| meta: {}, | ||
| name: 'header', | ||
| type: 'text', | ||
| defaultValue: 'default', | ||
| required: false, | ||
| subFields: [], | ||
| helperText: '', | ||
| autoFocus: false, | ||
| simpleTextOnly: false, | ||
| disallowRemove: false, | ||
| broadcast: false, | ||
| bubble: false, | ||
| hideFromUI: false, | ||
| hideFromFieldsEditor: false, | ||
| showTemplatePicker: true, | ||
| permissionsRequiredToEdit: '', | ||
| advanced: false, | ||
| copyOnAdd: true, | ||
| onChange: '', | ||
| behavior: '', | ||
| showIf: '', | ||
| mandatory: false, | ||
| hidden: false, | ||
| noPhotoPicker: false, | ||
| model: '', | ||
| supportsAiGeneration: false, | ||
| defaultCollapsed: false, | ||
| }, | ||
| ], | ||
| blocks: [ | ||
| { | ||
| '@type': '@builder.io/sdk:Element', | ||
| '@version': 2, | ||
| id: 'builder-ad60c140982d45f58d7190fd84481967', | ||
| component: { | ||
| name: 'Text', | ||
| options: { | ||
| text: 'HEADER:<br>', | ||
| }, | ||
| }, | ||
| responsiveStyles: { | ||
| large: { | ||
| display: 'flex', | ||
| flexDirection: 'column', | ||
| position: 'relative', | ||
| flexShrink: '0', | ||
| boxSizing: 'border-box', | ||
| marginTop: '20px', | ||
| lineHeight: 'normal', | ||
| height: 'auto', | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| '@type': '@builder.io/sdk:Element', | ||
| '@version': 2, | ||
| bindings: { | ||
| 'component.options.text': | ||
| 'var _virtual_index=state.header;return _virtual_index', | ||
| }, | ||
| code: { | ||
| bindings: { | ||
| 'component.options.text': 'state.header', | ||
| }, | ||
| }, | ||
| id: 'builder-3d3ef778f0734f259daa268388104ee0', | ||
| component: { | ||
| name: 'Text', | ||
| options: { | ||
| text: 'Enter some text...', | ||
| }, | ||
| }, | ||
| responsiveStyles: { | ||
| large: { | ||
| display: 'flex', | ||
| flexDirection: 'column', | ||
| position: 'relative', | ||
| flexShrink: '0', | ||
| boxSizing: 'border-box', | ||
| marginTop: '20px', | ||
| lineHeight: 'normal', | ||
| height: 'auto', | ||
| }, | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| metrics: { | ||
| clicks: 0, | ||
| impressions: 0, | ||
| }, | ||
| variations: {}, | ||
| lastUpdated: 1725874311648, | ||
| firstPublished: 1725873773459, | ||
| testRatio: 1, | ||
| createdBy: 'RuGeCLr9ryVt1xRazFYc72uWwIK2', | ||
| lastUpdatedBy: 'RuGeCLr9ryVt1xRazFYc72uWwIK2', | ||
| folders: [], | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| responsiveStyles: { | ||
| large: { | ||
| display: 'flex', | ||
| flexDirection: 'column', | ||
| position: 'relative', | ||
| flexShrink: '0', | ||
| boxSizing: 'border-box', | ||
| marginTop: '20px', | ||
| }, | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| metrics: { | ||
| clicks: 0, | ||
| impressions: 0, | ||
| }, | ||
| variations: {}, | ||
| lastUpdated: 1725874514331, | ||
| firstPublished: 1725874440040, | ||
| testRatio: 1, | ||
| createdBy: 'RuGeCLr9ryVt1xRazFYc72uWwIK2', | ||
| lastUpdatedBy: 'RuGeCLr9ryVt1xRazFYc72uWwIK2', | ||
| folders: [], | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.