Fix geolocation api setting always showing as enabled #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eadfp r=saschanaz readfp is deprecated since Python 3.2 Differential Revision: https://phabricator.services.mozilla.com/D190532
…ild-system-reviewers,sergesanspaille Differential Revision: https://phabricator.services.mozilla.com/D190285
…ortlib r=saschanaz CLOSED TREE Following the official migration guide from https://docs.python.org/3/whatsnew/3.12.html#imp Differential Revision: https://phabricator.services.mozilla.com/D190465
Ideally we wouldn't have to modify other files alongside - but it seems the .mozconfig doesn't override as it should. [WFX-358] Fix .mozconfig for linux.
Also includes: * [WFX-208] Improve support for bootstrapped extensions. Added support for custom preference pages. * [WFX-208] Fix incorrect loading order for bootstrap loader. * [WFX-394] Fix BootstrapLoader. (#2727)
Also includes: [WFX-186] Update GitHub Actions. Make sure we now package l10n files and have separate naming for ARM files on macOS. [WFX-249] Update GitHub Actions Squash of individual commits: [WFX-249] Add release action for current. [WFX-249] Use dispatch input for version number in release workflow. [WFX-249] Disable certain release triggers until ready for mass deployment. [WFX-249] Dry run AUS. [WFX-249] Add a pull workflow, improve staging/release process. [WFX-249] Attempt to set AWS env vars to prevent errors. [WFX-249] Update runners to handle stub-installer. [WFX-360] Improve AUS upload code for release.yml [WFX-186] Update PR workflow Co-Authored-By: adamp01 <[email protected]>
Use our own search extensions instead of Mozilla's.
Replaces [WFX-392], [WFX-367] and [WFX-245].
DO NOT modify license notices.
Signed-off-by: Alex Kontos <[email protected]>
* Keep sidebar showing after leaving fullscreen mode. * Respect user's choice about browser.tabs.insertAfterCurrent and browser.tabs.insertRelatedAfterCurrent
…atives r=ahochheiden (#3456) distutils.dir_util.copy_tree -> shutil.copytree distutils.spawn.find_executable -> shutil.which Also fix a warning about escape sequence in the process. Differential Revision: https://phabricator.services.mozilla.com/D194781 Co-authored-by: serge-sans-paille <[email protected]>
…. r=webrtc-reviewers,pehrsons,media-playback-reviewers,aosmond The keys inserted in the map come from GMPVideoEncodedFrame::TimeStamp, which returns a uint64_t, and truncation is probably not wanted, although it might just work in practice. Differential Revision: https://phabricator.services.mozilla.com/D197012
Tell cargo we've modified the code of rust-bindgen so the checksum verification of this crate should be skipped.
LAURAilway
changed the title
LAURAilway
changed the title
|
Note: Setting it to |
MrAlex94
force-pushed
the
current
branch
2 times, most recently
from
d1e5532
to
e35d968
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The radio buttons didn't correctly detect "" as a value, so the geolocation setting always appeared as "enabled" on reload, regardless of actual state. Setting the string for "disabled" to " " seems to fix the issue.
I am not entirely sure if this is bad practice for whatever reason, I defer that judgement to you.
Closes #3441