Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Oblivious DNS over HTTP to Oblivious DNS over HTTPS #3406

Closed
wants to merge 3 commits into from

Conversation

Dyras
Copy link

@Dyras Dyras commented Apr 3, 2024

Hello!

For some reason there is no S in Oblivious DNS over HTTPS almost anywhere in this project.

For example:
https://www.waterfox.net/blog/waterfox-in-2023/#dns-over-oblivious-http
https://www.waterfox.net/docs/releases/G6.0.1/

More importantly, it says Oblivious DNS over HTTP in the browser itself:
image

Is the implementation in Waterfox unencrypted, or is the missing S a typo?

Regardless, this fixes that in the descriptions/comments and in the en-US locale of the browser.

There are still functions named stuff like oblivious_http but I ain't touching that.

In an unrelated note, it seems impossible to use anything but CloudFlare for this feature. Any plans of changing that? Just curious.

Thanks for making this browser!

@MrAlex94
Copy link
Collaborator

MrAlex94 commented Apr 3, 2024

Thanks for taking the time to submit a PR! Oblivious HTTP is the correct usage of the term as you can see in the IETF proposal.

The reason being:

Focus on Application Layer: OHTTP primarily aims to obfuscate information at the HTTP request and response level, not the underlying transport layer. HTTPS, on the other hand, secures the connection itself. OHTTP builds on top of HTTPS for the secure transport, but its core function lies in making the HTTP request and response data invisible to intermediaries.

@MrAlex94 MrAlex94 closed this Apr 3, 2024
@Dyras Dyras deleted the patch-1 branch April 4, 2024 09:09
@Dyras
Copy link
Author

Dyras commented Apr 4, 2024

Well I be damned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants