Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconstruction functions for linearly acquired cartesian sequences #152

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

timwahoo
Copy link
Contributor

@timwahoo timwahoo commented Feb 1, 2024

Fixes #.148

Changes proposed in this pull request:

  • Added reconstruction functions that are similar to that done on bruker paravision 360 console.
  • reconstruction pipeline works for GRE, RARE, MSME, certain FLASH sequences where data was linearly acquired and returns complex images for each coil
  • To run from cmd use 'brkrecon test -i {pvdataset_zip_file}' (THIS FEATURE IS FOR TESTING PURPOSES)
  • otherwise run recon_testing.py from the testing folder

Issue: recoFunction cutoff function still has bugs with mismatch data sizes

@BrkRaw/Bruker

@dvm-shlee dvm-shlee self-assigned this Feb 1, 2024
@dvm-shlee dvm-shlee added the enhancement New feature or request label Feb 1, 2024
@dvm-shlee dvm-shlee added this to the v0.4.0 release milestone Feb 1, 2024
@dvm-shlee
Copy link
Member

@timwahoo, great work on this addition to the BrkRaw project – your efforts are truly appreciated! It seems we might need a few more steps to standardize the API, testing, and CLI. Nevertheless, your feature looks like a promising core module we can integrate into the broader brkraw library. It's great that it doesn't interfere with the original modules. I'll go ahead and merge this request and start working on the standardization process for the overall brkraw. Thanks again for your hard work, and I'm excited to see more of your contributions in the future!

@dvm-shlee dvm-shlee merged commit 407e869 into BrkRaw:main Feb 1, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants