Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]2430 check file existence in S3 in according to AWS documentation #2489

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mironovandrei
Copy link
Collaborator

@mironovandrei mironovandrei commented Feb 20, 2023

#2430
Use AWS recommended way to check if file exists in S3 bucket or not

@github-actions
Copy link

github-actions bot commented Feb 20, 2023

Gradle Unit and Integration Test Results

376 tests   - 99   366 ✔️  - 105   39s ⏱️ -22s
  81 suites  - 31       0 💤  -     4 
  81 files    - 31     10 +  10 

For more details on these failures, see this check.

Results for commit a69fb58. ± Comparison against base commit b955640.

This pull request removes 100 and adds 1 tests. Note that renamed tests count towards both.
com.epam.brn.integration.AuthorizationAuthenticationIT ‑ test create new user in local DB when login new firebase user()
com.epam.brn.integration.AuthorizationAuthenticationIT ‑ test get admin-users when don't have permission for it()
com.epam.brn.integration.AuthorizationAuthenticationIT ‑ test get groups authentication invalid token()
com.epam.brn.integration.AuthorizationAuthenticationIT ‑ test get groups authentication()
com.epam.brn.integration.CloudControllerAwsIT ‑ should get correct signature and policy for S3 upload()
com.epam.brn.integration.CloudControllerAwsIT ‑ should not upload non allowed file by extension file to S3()
com.epam.brn.integration.CloudControllerAwsIT ‑ should upload allowed file to S3()
com.epam.brn.integration.CloudControllerGoogleIT ‑ should get correct URL for upload()
com.epam.brn.integration.ContributorControllerIT ‑ test add contributor()
com.epam.brn.integration.ContributorControllerIT ‑ test get all contributors()
…
com.epam.brn.service.UrlConversionServiceTest ‑ should return empty map when picture doesn't exists()

♻️ This comment has been updated with latest results.

@github-actions
Copy link

Frontend test coverage: 45.59%

🤷‍♂️ Did not change

@github-actions
Copy link

Frontend test coverage: 45.59%

🤷‍♂️ Did not change

1 similar comment
@github-actions
Copy link

Frontend test coverage: 45.59%

🤷‍♂️ Did not change

@sonarcloud
Copy link

sonarcloud bot commented Feb 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link

Frontend test coverage: 45.59%

🤷‍♂️ Did not change

@github-actions
Copy link

Frontend test coverage: 45.59%

🤷‍♂️ Did not change

.build()
s3Client.headObject(request)
true
} catch (e: NoSuchKeyException) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation mentions S3Exception. I don't know if this is the recommendation or just an example. Anyway why did you use NoSuchKeyException instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants