-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]2430 check file existence in S3 in according to AWS documentation #2489
base: master
Are you sure you want to change the base?
Conversation
Gradle Unit and Integration Test Results376 tests - 99 366 ✔️ - 105 39s ⏱️ -22s For more details on these failures, see this check. Results for commit a69fb58. ± Comparison against base commit b955640. This pull request removes 100 and adds 1 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Frontend test coverage: 45.59% 🤷♂️ Did not change |
Frontend test coverage: 45.59% 🤷♂️ Did not change |
1 similar comment
Frontend test coverage: 45.59% 🤷♂️ Did not change |
Kudos, SonarCloud Quality Gate passed! |
Frontend test coverage: 45.59% 🤷♂️ Did not change |
Frontend test coverage: 45.59% 🤷♂️ Did not change |
.build() | ||
s3Client.headObject(request) | ||
true | ||
} catch (e: NoSuchKeyException) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation mentions S3Exception
. I don't know if this is the recommendation or just an example. Anyway why did you use NoSuchKeyException
instead?
#2430
Use AWS recommended way to check if file exists in S3 bucket or not