2311 be investigation refactoring jpa data classes #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Frontend test coverage: 95.45% 🤷♂️ Did not change |
Gradle Unit and Integration Test Results376 tests - 99 365 ✔️ - 106 35s ⏱️ -35s For more details on these failures, see this check. Results for commit 119ca9c. ± Comparison against base commit acf565b. This pull request removes 99 tests.♻️ This comment has been updated with latest results. |
|
Frontend test coverage: 95.45% 🤷♂️ Did not change |
AnatolVoluznev
changed the title
|
Frontend test coverage: 95.45% 🤷♂️ Did not change |
koylubaevnt
requested changes
Oct 17, 2022
src/test/kotlin/com/epam/brn/upload/csv/audiometrySpeech/LopotkoRecordProcessorTest.kt
Outdated
Show resolved
Hide resolved
ElenaSpb
reviewed
Oct 18, 2022
added 2 commits
October 25, 2022 10:12
…-classes # Conflicts: # src/main/kotlin/com/epam/brn/model/GitHubUser.kt
…g-jpa-data-classes' into 2311-be-investigation-refactoring-jpa-data-classes
|
Frontend test coverage: 95.45% 🤷♂️ Did not change |
|
Frontend test coverage: 95.45% 🤷♂️ Did not change |
|
Frontend test coverage: 95.45% 🤷♂️ Did not change |
added 5 commits
November 5, 2022 18:10
…g-jpa-data-classes' into 2311-be-investigation-refactoring-jpa-data-classes # Conflicts: # src/main/kotlin/com/epam/brn/service/TaskService.kt # src/main/kotlin/com/epam/brn/service/impl/UserAccountServiceImpl.kt # src/main/kotlin/com/epam/brn/upload/csv/seriesWords/SeriesWordsRecordProcessor.kt # src/main/kotlin/com/epam/brn/upload/csv/seriesWordsKoroleva/SeriesWordsKorolevaRecordProcessor.kt # src/test/kotlin/com/epam/brn/upload/csv/seriesMatrix/SeriesMatrixRecordProcessorTest.kt # src/test/kotlin/com/epam/brn/upload/csv/seriesWords/SeriesWordsRecordProcessorTest.kt # src/test/kotlin/com/epam/brn/upload/csv/seriesWordsKoroleva/SeriesWordsKorolevaRecordProcessorTest.kt
|
Frontend test coverage: 95.45% 🤷♂️ Did not change |
added 2 commits
November 20, 2022 10:53
…-classes # Conflicts: # src/main/kotlin/com/epam/brn/dto/response/WordsTaskResponse.kt # src/main/kotlin/com/epam/brn/model/Role.kt # src/main/kotlin/com/epam/brn/model/Task.kt # src/main/kotlin/com/epam/brn/model/UserAccount.kt # src/main/kotlin/com/epam/brn/service/impl/UserAccountServiceImpl.kt # src/main/kotlin/com/epam/brn/service/load/InitialDataLoader.kt # src/main/kotlin/com/epam/brn/upload/csv/audiometrySpeech/LopotkoRecordProcessor.kt # src/main/kotlin/com/epam/brn/upload/csv/seriesWords/SeriesWordsRecordProcessor.kt # src/main/kotlin/com/epam/brn/upload/csv/seriesWordsKoroleva/SeriesWordsKorolevaRecordProcessor.kt # src/test/kotlin/com/epam/brn/auth/filter/FirebaseTokenAuthenticationFilterTest.kt # src/test/kotlin/com/epam/brn/integration/UserDetailsControllerIT.kt # src/test/kotlin/com/epam/brn/service/TaskServiceTest.kt # src/test/kotlin/com/epam/brn/upload/csv/seriesMatrix/SeriesMatrixRecordProcessorTest.kt # src/test/kotlin/com/epam/brn/upload/csv/seriesWords/SeriesWordsRecordProcessorTest.kt # src/test/kotlin/com/epam/brn/upload/csv/seriesWordsKoroleva/SeriesWordsKorolevaRecordProcessorTest.kt
|
Frontend test coverage: 95.45% 🤷♂️ Did not change |
|
Kudos, SonarCloud Quality Gate passed! |
…-classes # Conflicts: # src/main/kotlin/com/epam/brn/dto/response/TaskResponse.kt # src/main/kotlin/com/epam/brn/model/Task.kt # src/main/kotlin/com/epam/brn/service/impl/UserAccountServiceImpl.kt # src/main/kotlin/com/epam/brn/upload/csv/seriesMatrix/SeriesMatrixRecordProcessor.kt # src/test/kotlin/com/epam/brn/service/TaskServiceTest.kt # src/test/kotlin/com/epam/brn/upload/csv/seriesMatrix/SeriesMatrixRecordProcessorTest.kt # src/test/kotlin/com/epam/brn/upload/csv/seriesWords/SeriesWordsRecordProcessorTest.kt # src/test/kotlin/com/epam/brn/upload/csv/seriesWordsKoroleva/SeriesWordsKorolevaRecordProcessorTest.kt
|
Frontend test coverage: 45.59% 🤷♂️ Did not change |
|
Kudos, SonarCloud Quality Gate passed! |
ElenaSpb
reviewed
Jan 28, 2023
| @@ -41,26 +41,6 @@ data class Headphones( | |||
| userAccount = userAccount?.id | |||
| ) | |||
|
|
|||
| override fun equals(other: Any?): Boolean { | |||
There was a problem hiding this comment.
why in this class equals is also deleted?
but in other classes not
ElenaSpb
reviewed
Feb 2, 2023
| @@ -11,6 +11,6 @@ data class TaskResponse( | |||
| val exerciseMechanism: ExerciseMechanism = exerciseType.toMechanism(), | |||
| val name: String? = "", | |||
| val serialNumber: Int? = 0, | |||
| val answerOptions: Set<ResourceResponse> = HashSet(), | |||
| val answerOptions: List<ResourceResponse> = mutableListOf(), | |||
There was a problem hiding this comment.
as we agree to change all sets into list
please check all other places and change them please
|
Frontend test coverage: 45.59% 🤷♂️ Did not change |
|
Frontend test coverage: 45.59% 🤷♂️ Did not change |
|
Frontend test coverage: 45.59% 🤷♂️ Did not change |
|
Frontend test coverage: 45.59% 🤷♂️ Did not change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2311: investigation refactoring jpa data classes