Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete Chaos Info #457

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Delete Chaos Info #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions engine/source/runtime/core/math/matrix4.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ namespace Piccolo
{
/** Class encapsulating a standard 4x4 homogeneous matrix.
@remarks
CHAOS uses column vectors when applying matrix multiplications,
Piccolo uses column vectors when applying matrix multiplications,
This means a vector is represented as a single column, 4-row
matrix. This has the effect that the transformations implemented
by the matrices happens right-to-left e.g. if vector V is to be
Expand All @@ -25,10 +25,10 @@ namespace Piccolo
inexplicably chosen to differ from the accepted standard and uses
row vectors and left-to-right matrix multiplication.
@par
CHAOS deals with the differences between D3D and OpenGL etc.
internally when operating through different render systems. CHAOS
Piccolo deals with the differences between D3D and OpenGL etc.
internally when operating through different render systems. Piccolo
users only need to conform to standard maths conventions, i.e.
right-to-left matrix multiplication, (CHAOS transposes matrices it
right-to-left matrix multiplication, (Piccolo transposes matrices it
passes to D3D to compensate).
@par
The generic form M * V which shows the layout of the matrix
Expand Down
5 changes: 2 additions & 3 deletions engine/source/runtime/core/math/random.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,9 @@ namespace Piccolo
template<typename... Params>
explicit DistRandomNumberGenerator(SeedType&& seeding, Params&&... /*params*/) : m_engine(seeding)
{
// m_dist = CHAOS_NEW_T(DistributionFunc)(std::forward<Params>(params)...);
}

~DistRandomNumberGenerator() { CHAOS_DELETE_T(m_dist); }
~DistRandomNumberGenerator() { delete m_dist; }

template<typename... Params>
void seed(Params&&... params)
Expand All @@ -97,4 +96,4 @@ namespace Piccolo
};

using DefaultRNG = RandomNumberGenerator<std::mt19937>;
} // namespace Chaos
} // namespace Piccolo
2 changes: 1 addition & 1 deletion engine/source/runtime/core/math/vector3.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ namespace Piccolo
returned vector will be on the side from which the arc from 'this'
to rkVector is anticlockwise, e.g. UNIT_Y.crossProduct(UNIT_Z)
= UNIT_X, whilst UNIT_Z.crossProduct(UNIT_Y) = -UNIT_X.
This is because CHAOS uses a right-handed coordinate system.
This is because Piccolo uses a right-handed coordinate system.
@par
For a clearer explanation, look a the left and the bottom edges
of your monitor's screen. Assume that the first vector is the
Expand Down
Loading