Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplified conftest and removed unused fixtures #10

Merged
merged 1 commit into from
Aug 19, 2024
Merged

simplified conftest and removed unused fixtures #10

merged 1 commit into from
Aug 19, 2024

Conversation

charlottekostelic
Copy link
Contributor

Fixed:

  • alphabetized methods within _ftpClient and _sftpClient classes

Removed:

  • unused fixtures from conftest
  • deduplicated and simplified mocks within conftest

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10457685120

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 10423879195: 0.0%
Covered Lines: 342
Relevant Lines: 342
💛 - Coveralls

@charlottekostelic charlottekostelic merged commit b38dbbe into main Aug 19, 2024
4 checks passed
@charlottekostelic charlottekostelic deleted the cleanup-conftest branch August 19, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlottekostelic @coveralls