Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored tests and increased coverage #1

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Conversation

charlottekostelic
Copy link
Contributor

Changed

  • retrieve_files() method to retrieve_file() in _ftpClient and _sftpClient

Added

  • exception handling for retrieve_files()
  • additional tests
  • marker for tests that require tmpdir or tmp_path

@charlottekostelic charlottekostelic merged commit 02e7c7a into main Jul 12, 2024
4 checks passed
@charlottekostelic charlottekostelic deleted the test_refactor branch July 12, 2024 17:09
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9911542330

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+19.3%) to 100.0%

Totals Coverage Status
Change from base Build 9893945914: 19.3%
Covered Lines: 114
Relevant Lines: 114

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants