Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit constraint on trace's encoding format #5132

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

ssssarah
Copy link
Contributor

@ssssarah ssssarah commented Sep 9, 2024

The current filter will filter out any ExperimentalTrace that has one of its distribution of encoding format something other than application/nwb.
In other words, if an ExperimentalTrace has multiple distributions, one being application/nwb and another being application/abf, the ExperimentalTrace would be filtered out, which is not what we want. The goal is to ensure there is at least one distribution of encoding format application/nwb

Copy link
Contributor

@crisely09 crisely09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ssssarah ssssarah merged commit 442e077 into master Sep 11, 2024
1 check passed
@imsdu imsdu deleted the trace_constraint branch September 16, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants