Add a dedicated workflow for static analysis (#4115)

* Add a dedicated workflow for static analysis --------- Co-authored-by: Simon Dumas <[email protected]>
BlueBrain · Jul 31, 2023 · ddb1f0b · ddb1f0b
1 parent 7b9a9c8
commit ddb1f0b
Show file tree

Hide file tree

Showing 10 changed files with 46 additions and 70 deletions.
diff --git a/.github/workflows/ci-delta-app.yml b/.github/workflows/ci-delta-app.yml
@@ -1,4 +1,4 @@
-name: Delta App
+name: Delta App unit tests
 on:
   pull_request:
     paths:
@@ -7,23 +7,7 @@ on:
       - 'project/**'
       - '.github/workflows/ci-delta-app.yml'
 jobs:
-  static-analysis:
-    if: github.event_name == 'pull_request'
-    runs-on: it
-    timeout-minutes: 10
-    env:
-      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v3
-        with:
-          fetch-depth: 0
-      - name: Static analysis
-        run: |
-          sbt -Dsbt.color=always -Dsbt.supershell=false \
-            clean \
-            app-static-analysis
-  unit-tests:
+  run:
     if: github.event_name == 'pull_request'
     runs-on: it
     timeout-minutes: 20

diff --git a/.github/workflows/ci-delta-core.yml b/.github/workflows/ci-delta-core.yml
@@ -1,4 +1,4 @@
-name: Delta Core
+name: Delta Core unit tests
 on:
   pull_request:
     paths:
@@ -12,24 +12,7 @@ on:
       - 'project/**'
       - '.github/workflows/ci-delta-core.yml'
 jobs:
-  static-analysis:
-    if: github.event_name == 'pull_request'
-    runs-on: it
-    timeout-minutes: 10
-    env:
-      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v3
-        with:
-          fetch-depth: 0
-      - name: Static analysis
-        run: |
-          sbt -Dsbt.color=always -Dsbt.supershell=false \
-            clean \
-            core-static-analysis
-
-  unit-tests:
+  run:
     if: github.event_name == 'pull_request'
     runs-on: it
     timeout-minutes: 20

diff --git a/.github/workflows/ci-delta-plugins.yml b/.github/workflows/ci-delta-plugins.yml
@@ -1,4 +1,4 @@
-name: Delta Plugins
+name: Delta Plugins unit tests
 on:
   pull_request:
     paths:
@@ -12,23 +12,7 @@ on:
       - 'project/**'
       - '.github/workflows/ci-delta-plugins.yml'
 jobs:
-  static-analysis:
-    if: github.event_name == 'pull_request'
-    runs-on: it
-    timeout-minutes: 10
-    env:
-      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v3
-        with:
-          fetch-depth: 0
-      - name: Static analysis
-        run: |
-          sbt -Dsbt.color=always -Dsbt.supershell=false \
-            clean \
-            plugins-static-analysis
-  unit-tests:
+  run:
     if: github.event_name == 'pull_request'
     runs-on: it
     timeout-minutes: 20

diff --git a/.github/workflows/ci-delta-static-analysis.yml b/.github/workflows/ci-delta-static-analysis.yml
@@ -0,0 +1,25 @@
+name: Delta Static analysis
+on:
+  pull_request:
+    paths:
+      - 'delta/**'
+      - 'build.sbt'
+      - 'project/**'
+      - '.github/workflows/ci-delta-static-analysis.yml'
+jobs:
+  run:
+    if: github.event_name == 'pull_request'
+    runs-on: ubuntu-latest
+    timeout-minutes: 20
+    env:
+      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+        with:
+          fetch-depth: 0
+      - name: Static analysis
+        run: |
+          sbt -Dsbt.color=always -Dsbt.supershell=false \
+            clean \
+            static-analysis
diff --git a/.github/workflows/ci-docs-ext-links.yml b/.github/workflows/ci-docs-ext-links.yml
@@ -5,7 +5,7 @@ on:
   workflow_dispatch:
 
 jobs:
-  review:
+  run:
     runs-on: ubuntu-latest
     timeout-minutes: 20
     steps:

diff --git a/.github/workflows/ci-docs.yml b/.github/workflows/ci-docs.yml
@@ -8,9 +8,9 @@ on:
       - '.github/workflows/ci-docs.yml'
 
 jobs:
-  static-analysis:
+  run:
     if: github.event_name == 'pull_request'
-    runs-on: it
+    runs-on: ubuntu-latest
     timeout-minutes: 20
     steps:
       - name: Checkout

diff --git a/.github/workflows/ci-github-docs.yml b/.github/workflows/ci-github-docs.yml
@@ -6,7 +6,7 @@ on:
       - 'README.md'
 
 jobs:
-  review:
+  run:
     if: github.event_name == 'pull_request'
     runs-on: ubuntu-latest
     timeout-minutes: 20

diff --git a/.github/workflows/ci-integration-tests.yml b/.github/workflows/ci-integration-tests.yml
@@ -9,7 +9,7 @@ on:
       - 'project/**'
       - '.github/workflows/ci-integration-tests.yml'
 jobs:
-  integration-tests:
+  run:
     runs-on: it
     timeout-minutes: 40
     env:

diff --git a/.github/workflows/ci-storage.yml b/.github/workflows/ci-storage.yml
@@ -9,7 +9,7 @@ on:
       - 'project/**'
       - '.github/workflows/ci-storage.yml'
 jobs:
-  review:
+  run:
     if: github.event_name == 'pull_request'
     runs-on: it
     timeout-minutes: 20

diff --git a/build.sbt b/build.sbt
@@ -1035,18 +1035,18 @@ addCommandAlias("build-docs", ";docs/clean;docs/makeSite")
 addCommandAlias("preview-docs", ";docs/clean;docs/previewSite")
 
 val coreModules = List("kernel", "rdf", "sdk", "sourcingPsql", "testkit")
-def staticAnalysisCommandForModule(module: String) =
+
+val staticAnalysis =
   s"""
-    |;$module/scalafmtCheck
-    |;$module/Test/scalafmtCheck
-    |;$module/scalafmtSbtCheck
-    |;$module/scapegoat
-    |;$module/doc
+    |project delta ;
+    |scalafmtSbtCheck ;
+    |scalafmtCheck ;
+    |Test/scalafmtCheck ;
+    |scapegoat ;
+    |doc
     |""".stripMargin
 
-addCommandAlias("core-static-analysis", coreModules.map(staticAnalysisCommandForModule).mkString)
-addCommandAlias("app-static-analysis", staticAnalysisCommandForModule("app"))
-addCommandAlias("plugins-static-analysis", staticAnalysisCommandForModule("plugins"))
+addCommandAlias("static-analysis", staticAnalysis)
 
 def unitTestsWithCoverageCommandsForModules(modules: List[String]) = {
   ";coverage" +