Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose changes in PR process #3

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

namcios
Copy link

@namcios namcios commented Jul 24, 2021

Update CONTRIBUTING.md with proposed changes in the PR review/edit process by maintainers. Also added some steps in PR creation process. Did not mention PR editing by non-maintainers because I believe that applies more to translations and not all repos (will create another PR for TRANSLATING.md where applicable).

Draft proposal. Please inform me of any further changes wanted/needed.

Discussed in Community Issue #62. Probably also applies to Community Issue #30.

@namcios
Copy link
Author

namcios commented Jul 24, 2021

Also mentioning @shannona here for review/feedback.

@ChristopherA ChristopherA marked this pull request as draft March 1, 2023 01:51
@shannona
Copy link
Collaborator

shannona commented Mar 7, 2023

Thanks for the updates @namcios.

For the "GPG signed commits" I'd suggest putting in a short listing (possibly as a separate doc) that actually provides the step-by-step of setting up signatures, as it's scattered here and is tricky. I think we just need:

(1) Setup a GPG signature
(2) Tell GitHub about the GPG Signature
(3) Example of how to use

[And tell people that of course they can use their own, existing signature if they want, and at that point just point them to the existing doc on how to do so for lots of different sigs. We just want to provide the steps by steps for people potentially unfamiliar with sigs at all.]

I also wonder about why we're suggesting that editors do so from the command line. I personally find it much simpler to go over PRs from the web interface, so I'm not sure why we're recommending the other as a default.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 2025 Backlog
Development

Successfully merging this pull request may close these issues.

2 participants