Skip to content
This repository has been archived by the owner on Jun 16, 2024. It is now read-only.

feat: implement rotate for three-column-layout #405

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

defer
Copy link

@defer defer commented Aug 4, 2022

Summary

Adds rotate/reverse rotate action handlers for the three-column-layout,
essentially turning it into a three-row-layout. This is useful for
screens where h > w (i.e. vertical scenario).

Breaking Changes

None

UI Changes

Before (no rotation):
before

After (rotated):
after

Test Plan

  1. Switch to three-column-layout, rotate.
  2. Eyeball it: switch between the three main scenarios (one-column, two-columns and three columns).

Related Issues

Relates to #397, #155

Adds rotate/reverse rotate action handlers for the three-column-layout,
essentially turning it into a three-row-layout. This is useful for
screens where h > w (i.e. vertical scenario).
@z0rgster
Copy link

z0rgster commented Mar 2, 2023

What's stopping this from being merged?

@tlaguz
Copy link

tlaguz commented Apr 3, 2023

There are three pull requests ( #408, #416 and this one ) solving the vertical monitor issues #155 and #397.
The lack of vertical slab layout is the main showstopper for me. It looks like this PR is the simplest fix.
Why this can't be merged?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants