-
Notifications
You must be signed in to change notification settings - Fork 36
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(apps/whale-api): api error when getting all data using OCG listin…
…g endpoint but response is empty (#2016) <!-- Thanks for sending a pull request! --> #### What this PR does / why we need it: - As titled, ~to allow `nextProvider` of `ApiPagedResponse.of` to be able to return `undefined`~ to enforce data and limit to be `> 0` in `ApiPagedResponse.of` - This is to fix the error on whale side currently when downstream is requesting all results using `listProposals()` and `listProposalVotes()` but response is empty. This is because on the upstream (`ain`) is using `size: 0` to return all results. - To add the previously skipped test cases #### Which issue(s) does this PR fixes?: <!-- (Optional) Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes # #### Additional comments?:
- Loading branch information
Showing
3 changed files
with
14 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters