Correctly handle mcols in get/setitem calls. (#3)

BiocPy · Oct 31, 2023 · 0c92797 · 0c92797
1 parent a21937c
commit 0c92797
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/iranges/IRanges.py b/src/iranges/IRanges.py
@@ -313,7 +313,7 @@ def __getitem__(
             start=self._start[idx],
             width=self._width[idx],
             names=ut.subset(self._names, idx) if self._names is not None else None,
-            mcols=self._mcols[list(idx), :],  # doesn't support ranges yet.
+            mcols=self._mcols[idx, :],
             metadata=self._metadata,
         )
 
@@ -337,7 +337,7 @@ def __setitem__(
         idx, scalar = ut.normalize_subscript(args, len(self), self._names)
         self._start[idx] = value._start
         self._width[idx] = value._width
-        #        self._mcols[list(idx),:] = value._mcols # doesn't support ranges yet.
+        self._mcols[idx, :] = value._mcols
 
         if value._names is not None:
             if self._names is None:

diff --git a/tests/test_IRanges.py b/tests/test_IRanges.py
@@ -114,10 +114,10 @@ def test_IRanges_setitem():
     assert (x.get_width() == np.array([4, 60, 70, 7])).all()
     assert x.get_names() is None
 
-    #    x = IRanges(starts, widths, mcols = BiocFrame({"foo": ['a', 'b', 'c', 'd']}))
-    #    y = IRanges(starts2, widths2, mcols = BiocFrame({"foo": ['A', 'B', 'C', 'D']}))
-    #    x[1:3] = y[1:3]
-    #    assert x.get_mcols().column("foo") == ['a', 'B', 'C', 'd']
+    x = IRanges(starts, widths, mcols=BiocFrame({"foo": ["a", "b", "c", "d"]}))
+    y = IRanges(starts2, widths2, mcols=BiocFrame({"foo": ["A", "B", "C", "D"]}))
+    x[1:3] = y[1:3]
+    assert x.get_mcols().column("foo") == ["a", "B", "C", "d"]
 
     x = IRanges(starts, widths, names=["a", "b", "c", "d"])
     y = IRanges(starts2, widths2, names=["A", "B", "C", "D"])