Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: better handle rule loading failures and give more information #1099

Merged
merged 3 commits into from
Jun 28, 2023
Merged

feat: better handle rule loading failures and give more information #1099

merged 3 commits into from
Jun 28, 2023

Conversation

gotbadger
Copy link
Contributor

@gotbadger gotbadger commented Jun 28, 2023 •
edited
Loading

Description

Deal with a few edge cases when loading rules

  • when we hit the ratelimit for dowloading the ruleset
  • unexpected status or content from rules download
  • stopping security report running when 0 rules are found previously this gave a very deceptive message that everything was ok but you had to scroll up to see 0 rules were applied
  • show rule version on security reoport

Related

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@gotbadger gotbadger marked this pull request as ready for review June 28, 2023 14:12
didroe
didroe approved these changes Jun 28, 2023
View reviewed changes
pkg/commands/process/settings/ruleLoader.go Outdated Show resolved Hide resolved
pkg/commands/process/settings/ruleLoader.go Outdated Show resolved Hide resolved
@gotbadger gotbadger merged commit 94c4fc6 into main Jun 28, 2023
5 checks passed
@gotbadger gotbadger deleted the feat/warn-on-no-rules branch June 28, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didroe didroe didroe approved these changes

@cfabianski cfabianski Awaiting requested review from cfabianski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No warning when rules are not downloaded
2 participants
@gotbadger @didroe