Feature: add admin pages for site-wide handle_info callbacks #210
+401
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddink
changed the title
ddink
force-pushed
the
site_wide_handle_info_callbacks_feature
branch
from
efbf7f3
to
15ffa88
Compare
leandrocp
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Thanks! Will be merged soon along with BeaconCMS/beacon#578
|
@ddink this PR is scheduled in the v0.1.0 release, we are just finishing some materials, in the mean time feel free to use the Thanks ❤️ |
leandrocp
pushed a commit
that referenced
this pull request
Oct 9, 2024
|
Hey @ddink just release v0.1.0 with these changes https://github.com/BeaconCMS/beacon_live_admin/releases/tag/v0.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What will it allow you to do that you can't do today?
These changes will make it possible to administrate the site-wide
handle_infocallbacks that will be applied to each Beacon page.Why do you need this feature and how will it benefit other users?
This feature will give users the ability to handle messages sent by
Kernel.send/2. Commonly, this can be used to do things like put flash messages, navigate to another LiveView, work with streams, etc. in response to messages sent by the application.Are there any drawbacks to this feature?
This feature is not designed to create page-specifichandle_infocallbacks—just site-wide callbacks that are useable on all of a site’s pages. I’m happy to add a page-specifichandle_infocallbacks feature at a later point, though.Changes tohandle_infocallbacks through the admin require a recompile before they are useable. They are not immediately useable upon a refresh of a Beacon page the way that an update to a Beacon page is immediately viewable.