Shared event handlers #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandrocp
reviewed
Aug 21, 2024
| @@ -124,10 +125,10 @@ defmodule Beacon.Loader.Page do | |||
| end | |||
|
|
|||
| defp handle_event(page) do | |||
| %{site: site, event_handlers: event_handlers} = page | |||
| event_handlers = Content.list_event_handlers(page.site) | |||
There was a problem hiding this comment.
There's still one step missing here :)
Whenever an event handler changes we'd need to broadcast a message to recompile all page modules so I'm wondering if it would be better to create a new EventHandler module containing all handle_event and on the handle_event of PageLive here
beacon/lib/beacon/web/live/page_live.ex
Lines 70 to 76 in ce916b5
We just replace page_module with event_handler_module.
In this case whenever an event handler changes we only recompile the single event handler module and save resources by not duplicating the same event_handler on all page modules.
Wdyt?
now that's loaded in a separate module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #519