Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Test MySQL and MS SQL databases in CI #447

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Conversation

APB9785
Copy link
Contributor

@APB9785 APB9785 commented Apr 12, 2024

No description provided.

@APB9785 APB9785 self-assigned this Apr 12, 2024
@APB9785 APB9785 linked an issue Apr 12, 2024 that may be closed by this pull request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can create another workflow file to run only on main instead of changing this one. So on every PR it would run tests for Postgres (fast and the most popular vendor) and on main it would run for others so we make sure Beacon runs on all official adapters but doesn't take too long to run tests on PRs. Wdyt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI - run tests on multiple databases
2 participants