[FEAT] api 이쁘게 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit cdb4ece): https://batshu-c203f--pr6-feature-api-9qipgjrq.web.app (expires Thu, 28 Sep 2023 01:59:50 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 83b3acd7145a633c2e47144814099f2df4c43e54 |
bluejoyq
requested changes
Sep 19, 2023
src/domain/apiPaths.ts
Outdated
There was a problem hiding this comment.
이거 queryWrapper 쓸거면 템플릿타입으로 아예 타입도 정하는게 좋지 않을까.
default 타입으로 record쓰고
There was a problem hiding this comment.
원래 따로 뒀다가 response타입도 다 여기있길래 여기에 넣음 따로 둘거면 다 옮기는 쪽으로 안그럼 똑같은 타입 두번 정의해야됨..
There was a problem hiding this comment.
@HYEOK9 어디 공통으로 dto만 정의하고 import하는 방향은 어떤가요!
There was a problem hiding this comment.
일단 endpoint만 빼놓음 옮기고 싶은거 있음 옮기고 머지 ㄱ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.