Fix #263 Dataview Representation

BabylonJS · Jun 26, 2023 · 131d7ab · 131d7ab
1 parent b780db6
commit 131d7ab
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 5 deletions.
diff --git a/dist/spector.bundle.js b/dist/spector.bundle.js
diff --git a/documentation/changeLogs.md b/documentation/changeLogs.md
@@ -7,6 +7,7 @@ Please, find below the per release summary of the contribution added to the proj
 ## v0.9.30
 * Fix [Scissor function call](https://github.com/BabylonJS/Spector.js/issues/266)
 * Fix [bufferSubData and getAttribLocation number report](https://github.com/BabylonJS/Spector.js/issues/262)
+* Fix [Dataview representation](https://github.com/BabylonJS/Spector.js/issues/263)
 
 ## v0.9.29
 * Add [WebXR tracking capabilities](https://github.com/BabylonJS/Spector.js/pull/257)

diff --git a/extensions/spector.bundle.func.js b/extensions/spector.bundle.func.js
diff --git a/extensions/spector.bundle.js b/extensions/spector.bundle.js
diff --git a/src/backend/commands/baseCommand.ts b/src/backend/commands/baseCommand.ts
@@ -86,7 +86,7 @@ export abstract class BaseCommand {
         if (args && args.length > 0) {
             stringified += ": " + this.stringifyArgs(args).join(", ");
         }
-        if (result) {
+        if (result !== undefined && result !== null) {
             stringified += " -> " + this.stringifyResult(result);
         }
         return stringified;
@@ -164,6 +164,11 @@ export abstract class BaseCommand {
             return "[..(" + value.length + ")..]";
         }
 
+        // DataView
+        if (value.byteLength) {
+            return "[..(" + value.byteLength + ")..]";
+        }
+
         return value;
     }
 }
diff --git a/src/backend/commands/getAttribLocation.ts b/src/backend/commands/getAttribLocation.ts
@@ -8,7 +8,7 @@ export class GetAttribLocation extends BaseCommand {
     }
 
     protected stringifyResult(result: any): string {
-        if (!result) {
+        if (result === undefined || result === null) {
             return undefined;
         }