feat: new architecture support #659
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I do a full reload of metro, I get this error:
Have you run into this issue before? It comes from BabylonNative source code so my guess is that we are calling reset() at wrong time Edit: Looks like its caused by the order in which invalidate is now called. This function is called later in new architecture 👎🏻 + (void)invalidate
{
BabylonNative::Deinitialize();
} |
|
Everything works as expected when I add an early return in the dispose function. Is it possible that we don't need this for new architecture? I don't know the backstory but maybe it addressed issue with deinitializing the native view on old arch? public dispose(): void {
if (!this.isDisposed) {
+ return;
super.dispose();
BabylonNative.resetInitializationPromise();
reset();
this._isDisposed = true;
}
}
|
okwasniewski
force-pushed
the
feat/new-arch
branch
from
45b44ad
to
865c6c1
Compare
|
On Android Im getting instant crash when building TestApp. Not sure if this is reproducible on your end? I'm attaching my logcat stacktrace below: Logcat error |
|
Well.. I got Android (Old Arch to work in the Release build variant) not sure if this is a known issue?
|
okwasniewski
force-pushed
the
feat/new-arch
branch
2 times, most recently
from
8c8cb5b
to
3ebf766
Compare
okwasniewski
commented
Oct 3, 2024
| @Override | ||
| public List<NativeModule> createNativeModules(ReactApplicationContext reactContext) { | ||
| return Arrays.<NativeModule>asList(new BabylonModule(reactContext)); | ||
| } | ||
|
|
||
| @NonNull | ||
| @Override | ||
| public List<ViewManager> createViewManagers(ReactApplicationContext reactContext) { | ||
| return Arrays.<ViewManager>asList(new EngineViewManager()); |
There was a problem hiding this comment.
Add comment here to explain how EngineViewManager is picked for arch
okwasniewski
force-pushed
the
feat/new-arch
branch
from
3ebf766
to
2cf3c73
Compare
|
Hey @bghgary @CedricGuillemet @ryantrem Here are the resources I've used for this migration:
Im going to get back to working on this when we get this 0.73+ JSI access issue fixed |
|
@okwasniewski I get the same build error for RNTA Windows when the RN versions in package.json are different from current master values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
This PR introduces new architecture support. It builds off the #654 PR. (So it would be great if we could land it first)
You can review only this commit: 45b44ad
Known issues
TODO
Screenshots
Testing
Try to build the app using new architecture