Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build system with RNTA for RN 0.73+ #647

Draft
wants to merge 66 commits into
base: master
Choose a base branch
from

Conversation

CedricGuillemet
Copy link
Contributor

@CedricGuillemet CedricGuillemet commented Jun 17, 2024

WIP
Goals:

  • use RNTA and deprecate old playgrounds
  • faster builds using more splitting
  • upload artifacts at different steps, for all platforms, to ease debugging
  • build and test publishing for less surprises when cutting a new npm

Done :

  • use a git patch to select RN and apply dependency changes.
  • Split builds. with enough agents, should be <25min overall
  • Test publishing (dry run) for every PR. overhead is very acceptable now
  • Replace download-artifact with v4 as v2 is deprecated
  • New RN versions (0.73+) will use RNTA build to produce the package. Legacy buildis kept until being replaced with deprecated versions
  • Testable Windows Artifacts
  • Clean up build warnings
  • produce testable artifacts (ios/android apk)
  • Tests with legacy build
  • factorize yml so PR and publish are same processes

Issues:

  • BRNPlayground build with basekit on windows: issue with dependencies in vcxproj
  • windows patched versions do not build
  • x86 does not build. is it still needed?
  • Running produced Android artifact gives only a black screen

later:

  • Use BabylonNative prebuilt (gain on Windows is <2min. unknown gain on iOS/Android)
  • VisionOS


- name: NPM Install (Playground)
- name: Patch BRNPlayground for RN ${{ matrix.react-native-version }}
run: git apply rnta-${{ matrix.react-native-version }}.patch --allow-empty
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do this as part of a script that is easy to run locally? Like the npm run select 0.71 we currently have?

@CedricGuillemet CedricGuillemet changed the title Use patch to select RN version for RNTA Select RN version script for RNTA Jun 18, 2024
@CedricGuillemet CedricGuillemet changed the title Select RN version script for RNTA Build system with RNTA for RN 0.73+ Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants