Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix podspec include path for BabylonInterop #616

Merged
merged 2 commits into from
Oct 24, 2023
Merged

fix podspec include path for BabylonInterop #616

merged 2 commits into from
Oct 24, 2023

Conversation

CedricGuillemet
Copy link
Contributor

add include path in podspec so including BabylonNative works with 'Legacy' BRN package or with #615

@CedricGuillemet CedricGuillemet marked this pull request as ready for review October 23, 2023 16:12
@CedricGuillemet CedricGuillemet mentioned this pull request Oct 24, 2023
Draft
8 tasks
bghgary
bghgary approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@bghgary bghgary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about podspec files, so maybe @ryantrem can take a quick look before we merge.

@CedricGuillemet CedricGuillemet enabled auto-merge (squash) October 24, 2023 17:38
@CedricGuillemet CedricGuillemet merged commit 073ed48 into BabylonJS:master Oct 24, 2023
20 checks passed
@CedricGuillemet CedricGuillemet mentioned this pull request Nov 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantrem ryantrem ryantrem approved these changes

@bghgary bghgary bghgary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CedricGuillemet @ryantrem @bghgary