Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake Fetchcontent instead of submodules #613

Merged
merged 19 commits into from
Oct 25, 2023

Conversation

CedricGuillemet
Copy link
Contributor

@CedricGuillemet CedricGuillemet commented Oct 17, 2023

To be more consistent with BN, easier updates to different BabylonNative version and prepare the work to use prebuilt BN.

  • fix issue with arcore. "windows build agents don't support the path lengths required for initializing arcore dependencies". module is not fetched anymore on Windows.
  • Remove code to update submodule in gulp.js , tools.js andjobs .yml
  • Code to update submodule to the latest in gulp.js is removed. Now change the commit id in shared/CMakeLists.txt

Notes:

  • Using fetch populate and add_subdirectory after instead of makeAvailable because of binary directory differences of platforms. This is something I'll try to revisit in upcoming PRs.
  • There is a check to not populate multiple times in shared/CMakeLists.txt. With iOS build, I got an error saying it's already populated. I'm sure why this happens.

This change needs BabylonJS/BabylonNative#1312

@CedricGuillemet CedricGuillemet marked this pull request as ready for review October 18, 2023 12:22
Copy link
Contributor

@bghgary bghgary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me

@CedricGuillemet CedricGuillemet merged commit 6617896 into BabylonJS:master Oct 25, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants