Exclude XR and camera libs from basekit podspec #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't the files themselves (e.g. libxr.a) be excluded from the package? Then the podspec doesn't need to change. Alternatively, if we must include unused libs in the package for some reason, is there some kind of podspec exclusion syntax, so we can still include *.a but then exclude specific libs? |
|
excluding .a from the package needs some work in the gulp file and it's starting to be (a little) convoluted and hard to maintain. I don't want to add cases where files are deleted at some steps. In the pod spec, I tried to use |
ryantrem
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XR, nativeXR and nativeCamera libraries are not excluded from BaseKit podspec resulting in missing symbols at link times.
List libraries explicitely to fix the issue.