Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove xr/camera build targets for basekit #605

Merged
merged 13 commits into from
Sep 28, 2023
Merged

Remove xr/camera build targets for basekit #605

merged 13 commits into from
Sep 28, 2023

Conversation

CedricGuillemet
Copy link
Contributor

@CedricGuillemet CedricGuillemet commented Sep 25, 2023 •
edited
Loading

  • Enable dry-run publish via optional GitHub action parameter
  • Generate PG apps for basekit packages
  • Disable build & link NativeXr and NativeCamera for basekit packages. libarcore.so is loaded even if xr plugin is not instanciated

Dry run tested here : https://github.com/CedricGuillemet/BabylonReactNative-1/actions/runs/6300966856

@CedricGuillemet CedricGuillemet marked this pull request as ready for review September 25, 2023 16:21
@CedricGuillemet CedricGuillemet merged commit 6dc5352 into BabylonJS:master Sep 28, 2023
20 checks passed
@CedricGuillemet CedricGuillemet mentioned this pull request Sep 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantrem ryantrem ryantrem approved these changes

@bghgary bghgary Awaiting requested review from bghgary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CedricGuillemet @ryantrem