Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BN submodule #589

Merged
merged 11 commits into from
Jul 20, 2023
Merged

Update BN submodule #589

merged 11 commits into from
Jul 20, 2023

Conversation

CedricGuillemet
Copy link
Contributor

@CedricGuillemet CedricGuillemet commented Jul 18, 2023 •
edited
Loading

Update BN to have this particular commit in : BabylonJS/BabylonNative@c89031e

ryantrem
ryantrem reviewed Jul 18, 2023
View reviewed changes
Copy link
Member

@ryantrem ryantrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I recently tested, cmake 3.25+ didn't work with BRN for iOS because of a cmake change with location of built archive (static lib) files, which resulted in linker errors. @bghgary has more details on this.

.github/workflows/ios_android.yml Outdated Show resolved Hide resolved
@CedricGuillemet CedricGuillemet merged commit ca1663f into BabylonJS:master Jul 20, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantrem ryantrem ryantrem left review comments

@bghgary bghgary bghgary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CedricGuillemet @ryantrem @bghgary