Implement constant-time hash ordering #420
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as draft for now, since #419 would add |
AaronFeickert
force-pushed
the
hash-ord
branch
from
4dd2aba
to
188526e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements constant-time ordering (and partial ordering) for
Hash, but does so differently than #267 and #370.It uses
subtleinternally to lexicographically compare corresponding bytes, being careful not to short circuit. This simplifies the logic considerably.Note that it does not use
subtleto implementPartialEq; this functionality exists in #419 since it seemed better scoped for a separate PR. However, if #419 is implemented, it will be possible to implementConstantTimeGreaterandConstantTimeLessdue to the latter requiring aConstantTimeEqtrait bound included in that PR.