Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to prepare GA Spring Monitor #41909

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Changes to prepare GA Spring Monitor #41909

wants to merge 6 commits into from
+42 −49

Conversation

jeanbisutti
Copy link
Contributor

@jeanbisutti jeanbisutti commented Sep 18, 2024 •
edited
Loading

  • Package renaming
  • package info
  • ...

@github-actions github-actions bot added the azure-spring All azure-spring related issues label Sep 18, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure.spring:spring-cloud-azure-starter-monitor

@jeanbisutti jeanbisutti marked this pull request as draft September 18, 2024 14:07
@jeanbisutti jeanbisutti changed the title Rename Spring Monitor package Chnages to prepare GA Spring Monitor Sep 18, 2024
@jeanbisutti jeanbisutti changed the title Chnages to prepare GA Spring Monitor Changes to prepare GA Spring Monitor Sep 18, 2024
@jeanbisutti jeanbisutti marked this pull request as ready for review September 18, 2024 14:26
saragluna
saragluna approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@saragluna saragluna saragluna approved these changes

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft alzimmermsft is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@rujche rujche Awaiting requested review from rujche rujche is a code owner

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy is a code owner

@moarychan moarychan Awaiting requested review from moarychan moarychan is a code owner

@ramthi ramthi Awaiting requested review from ramthi ramthi is a code owner

@heyams heyams Awaiting requested review from heyams heyams is a code owner

@harsimar harsimar Awaiting requested review from harsimar harsimar is a code owner

Assignees
No one assigned
Labels
azure-spring All azure-spring related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeanbisutti @azure-sdk @trask @saragluna