-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ErrorDetail model #30572
base: main
Are you sure you want to change the base?
Add ErrorDetail model #30572
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Generated ApiView
|
|
||
@doc("The details of an error.") | ||
@error | ||
model ErrorDetail { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why cant we just do model ErrorDetail is Foundations.Error
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These errors look like you tried to define the model inline on the property which is not supported syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you just need to define the model independently and then refer to it in the property field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If using model ErrorDetails is Foundations.Error
is too complicated to get to work with the emitters, then let's make sure the models you add to the spec match the service's rest api.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The models are consisting with what we are using now. We can use Foundations.Error
when emitter supports renaming on it.
Looks good from Java SDK perspective. |
No description provided.