Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing the Azure Review comments #30549

Closed
wants to merge 13 commits into from
Closed

Addressing the Azure Review comments #30549

wants to merge 13 commits into from

Conversation

v-vdharmaraj
Copy link

Data Plane API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

  • Design Document:
  • Previous API Spec Doc:
  • Updated paths:

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

Getting help

  • First, please carefully read through this PR description, from top to bottom.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

mikeharder and others added 13 commits September 11, 2024 14:54
@mikeharder
Reduce minimum npm version from 10 to 9 (#30522)
0d3e858 
- Dependabot still uses 9.6.5
@mikeharder
Update package-lock.json for engines change (#30524)
9e0f1f0
@dependabot
Bump @azure-tools/typespec-client-generator-cli from 0.12.2 to 0.13.0 (…
805491e 
…#30523)

Bumps [@azure-tools/typespec-client-generator-cli](https://github.com/Azure/azure-sdk-tools) from 0.12.2 to 0.13.0.
- [Release notes](https://github.com/Azure/azure-sdk-tools/releases)
- [Commits](https://github.com/Azure/azure-sdk-tools/commits)

---
updated-dependencies:
- dependency-name: "@azure-tools/typespec-client-generator-cli"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@stevemunk @jhendrixMSFT
Removed the retired data service. (#30517)
d9bed93 
Co-authored-by: Joel Hendrix <[email protected]>
@jlian
Update IoT Operations examples (#30451)
60bf189 
* New service and SAT values in examples

* New configMap name in examples

* Update examples in the other folder too
@qfai
[developerhub] Update private preview 2024-05-01-preview (#30333)
14ac81f 
* change typo

* fix ci issu

* fix model validation error

* add all quick start template type

---------

Co-authored-by: qfai <[email protected]>
@FumingZhang @calvin197 @skuchipudi295
Review request for Microsoft.ContainerService/aks to add version prev…
e38a6d8 
…iew/2024-07-02-preview (#30395)

* Adds base for updating Microsoft.ContainerService/aks from version preview/2024-06-02-preview to version 2024-07-02-preview

* Updates readme

* Updates API version in new specs and examples

* Add driverType property to AKS AgentPoolGPUProfile (#30094)

* Add driverType property to AgentPoolGPUProfile

* Update managedClusters.json

* Update managedClusters.json

* remove outdated constrains about vm profile from description

* addressing breaking change concerns

* fix CI failures

* align with stable API

---------

Co-authored-by: Calvin S. <[email protected]>
Co-authored-by: skuchipudi295 <[email protected]>
@ChenxiJiang333
Update readme.python.md (#30528)
b40c396
@schaudhari6254888
[ServiceBus] 2024-01-01 (#30331)
4e5b64a 
* BASE commit

* Adding new api-version=2024-01-01

* Readme file updated

* Updates in failover api

* Readme correction'

* Readme correction again'

* Common-datatype updates

* Common-datatype removed ErrorResponse it is causing breaking change

* Updated common-types

* Updates

* more updates

---------

Co-authored-by: Your Name <[email protected]>
@rzhelenchuk @eliagrady @talco77
Review request for Microsoft.Security to add version stable/2024-08-01 (
317b997 
#30235)

* Review request for Microsoft.Security to add version stable/2023-08-01

* fix

* fixes

* Change version

* fix perttier check

* update readme

* added custom recommendation type

* update reademe

* prettier

* prettier

* fixed modelling issue

* fix

* prettier

* fix

* remove next link

* revert

* fix

* addressed comments

* addressed comments

* addressed comments

* addressed comments

* fix model validation

* addressed comments

* Fixes after CR

* change to v1

* add body

* merge #/definitions/CustomRecommendationRequestBody to #/definitions/CustomRecommendation

* seperate request properties

* fix lint errors

* fixed systemdata examples

---------

Co-authored-by: Tal Cohen <[email protected]>
Co-authored-by: Elia Grady <[email protected]>
Co-authored-by: talco77 <[email protected]>
Co-authored-by: Elia Grady <[email protected]>
@ChenxiJiang333 @msyyc
Update tspconfig for Python SDK (#30503)
55607c6 
* update tspconfig

* Update tspconfig.yaml

---------

Co-authored-by: Yuchao Yan <[email protected]>
@chrisradek
Upgrade/typespec 0.60 (#30511)
cc91e09
@YalinLi0312
Fix lro wrong return type in AppConfig (#30548)
34f5146
@openapi-pipeline-app openapi-pipeline-app
Copy link

PR validation pipeline started successfully. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

@openapi-pipeline-app openapi-pipeline-app
Copy link

PR validation pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard will be requested when the pull request is marked ready for review weshaggard is a code owner

@mikeharder mikeharder Awaiting requested review from mikeharder mikeharder will be requested when the pull request is marked ready for review mikeharder is a code owner

@msyyc msyyc Awaiting requested review from msyyc msyyc will be requested when the pull request is marked ready for review msyyc is a code owner

@v-Ajnava v-Ajnava Awaiting requested review from v-Ajnava v-Ajnava will be requested when the pull request is marked ready for review v-Ajnava is a code owner

@dsouzaarun dsouzaarun Awaiting requested review from dsouzaarun dsouzaarun will be requested when the pull request is marked ready for review dsouzaarun is a code owner

@damodaravadhani damodaravadhani Awaiting requested review from damodaravadhani damodaravadhani will be requested when the pull request is marked ready for review damodaravadhani is a code owner

@NonStatic2014 NonStatic2014 Awaiting requested review from NonStatic2014 NonStatic2014 will be requested when the pull request is marked ready for review NonStatic2014 is a code owner

@Kishp01 Kishp01 Awaiting requested review from Kishp01 Kishp01 will be requested when the pull request is marked ready for review Kishp01 is a code owner

@marcodalessandro marcodalessandro Awaiting requested review from marcodalessandro marcodalessandro will be requested when the pull request is marked ready for review marcodalessandro is a code owner

@rohankhandelwal rohankhandelwal Awaiting requested review from rohankhandelwal rohankhandelwal will be requested when the pull request is marked ready for review rohankhandelwal is a code owner

@riteshrao riteshrao Awaiting requested review from riteshrao riteshrao will be requested when the pull request is marked ready for review riteshrao is a code owner

@palma21 palma21 Awaiting requested review from palma21 palma21 will be requested when the pull request is marked ready for review palma21 is a code owner

@matthchr matthchr Awaiting requested review from matthchr matthchr will be requested when the pull request is marked ready for review matthchr is a code owner

@yangyuan yangyuan Awaiting requested review from yangyuan yangyuan will be requested when the pull request is marked ready for review yangyuan is a code owner

@wiboris wiboris Awaiting requested review from wiboris wiboris will be requested when the pull request is marked ready for review wiboris is a code owner

@dpwatrous dpwatrous Awaiting requested review from dpwatrous dpwatrous will be requested when the pull request is marked ready for review dpwatrous is a code owner

@skapur12 skapur12 Awaiting requested review from skapur12 skapur12 will be requested when the pull request is marked ready for review skapur12 is a code owner

@cRui861 cRui861 Awaiting requested review from cRui861 cRui861 will be requested when the pull request is marked ready for review cRui861 is a code owner

@wanghoppe wanghoppe Awaiting requested review from wanghoppe wanghoppe will be requested when the pull request is marked ready for review wanghoppe is a code owner

@hmlam hmlam Awaiting requested review from hmlam hmlam will be requested when the pull request is marked ready for review hmlam is a code owner

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel will be requested when the pull request is marked ready for review lmazuel is a code owner

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen deyaaeldeen will be requested when the pull request is marked ready for review deyaaeldeen is a code owner

@JoshLove-msft JoshLove-msft Awaiting requested review from JoshLove-msft JoshLove-msft will be requested when the pull request is marked ready for review JoshLove-msft is a code owner

@swathipil swathipil Awaiting requested review from swathipil swathipil will be requested when the pull request is marked ready for review swathipil is a code owner

@conniey conniey Awaiting requested review from conniey conniey will be requested when the pull request is marked ready for review conniey is a code owner

@minhanh-phan minhanh-phan Awaiting requested review from minhanh-phan minhanh-phan will be requested when the pull request is marked ready for review minhanh-phan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.