Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release-network-2024-03-01 to main #26136

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

msJinLei
Copy link
Contributor

@msJinLei msJinLei commented Sep 19, 2024

Description

@kamboj-prjwl As the network release branch contains a lot of important changes, it is risky to merge it at the latest minute. I am merging the release-network-2024-03-01 branch to main. Please review the PR.

After the PR is merged, release-network-2024-03-01 should be deleted and #26091 and #25810 should be retargeting to main branch

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

YanaXu and others added 12 commits July 26, 2024 17:25
* PS Changes for User Managed Identity

* update changeLog.md

* update changeLog.md

* Update ChangeLog.md

* updating New-AzNetworkWatcherFlowLog.md file

---------

Co-authored-by: Yabo Hu <[email protected]>
…wlogs (Azure#25709)

* Powershell code changes to support new field in flowlogs

* adding unit tests

* Help generation

* Generated flowlogs related files

* Revert "Generated flowlogs related files"

This reverts commit 4e7c8c0.

* add changeLog.md

* Reapply "Generated flowlogs related files"

This reverts commit 0b7db60.

* Adding session records

* Revert "Reapply "Generated flowlogs related files""

This reverts commit b17598d.

* Modified  TestVnetFlowLogWithEmptyFilteringCondition and TestVnetFlowLogWithFiltering

* Help files

* Model generated flowlogs files

* Commit added to ReadMe file against 2024-03-01

* Checking in all the generated files

---------

Co-authored-by: Mansi Verma <[email protected]>
Removed noHealthyBackendsBehavior directive.
…ule Override (Azure#25705)

* sensitivity add

* add back deleted rule

* add back deleted rule

* removed bracket

* merge conf

* edit comment and add nuget

* retry test

* fix test

* edit sdk

* edit test
* fixing packet capture call to be async

* fixing the test to return success

* replaced the hard coded sasurl with sasurl generated on the fly

* Adding session record for the fixed test

* adding change summary to changelog.md

* skipping test in cloud runner due to issues accessing deployed storage account

* removing storage account actions, replacing the sessions recording and replacing the sasurl with a dummySAS as per recommendation

* mask sas url in record json

---------

Co-authored-by: Yabo Hu <[email protected]>
* Init

* Adding help content

* Update test run

* Null check

* Update ChangeLog.md

* Update help

* Update test result

* Minor string changes

* Update ChangeLog.md

* Updating BSL label

* Update help

* Update Remove-AzBastionShareableLink.md

* Update ChangeLog.md

---------

Co-authored-by: Abhishek Shah <[email protected]>
Co-authored-by: Jin Lei <[email protected]>
* Add destination IP address as parameter for PLS

* Make Loadbalancer non required
Copy link

azure-client-tools-bot-prd bot commented Sep 19, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ApplicationInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Az.Batch
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.CognitiveServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.Compute
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.ContainerRegistry
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.CosmosDB
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.DataLakeStore
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.Dns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.EventHub
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.NetAppFiles
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
⚠️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Get-AzBastionShareableLink 1 1 Unassigned_Variable Get-AzBastionShareableLink -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName.
⚠️ Get-AzBastionShareableLink 1 1 Unassigned_Variable Get-AzBastionShareableLink -Name $bastionName is a null-valued parameter value. -Name Assign value for $bastionName.
⚠️ Get-AzBastionShareableLink 2 1 Unassigned_Variable Get-AzBastionShareableLink -InputObject $bastion is a null-valued parameter value. -InputObject Assign value for $bastion.
⚠️ Get-AzBastionShareableLink 2 1 Unassigned_Variable Get-AzBastionShareableLink -TargetVmId $vm1.Id is a null-valued parameter value. -TargetVmId Assign value for $vm1.Id.
⚠️ New-AzApplicationGatewayFirewallPolicyManagedRuleOverride 1 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicyManagedRuleOverride -RuleId $ruleId is a null-valued parameter value. -RuleId Assign value for $ruleId.
⚠️ New-AzApplicationGatewayFirewallPolicyManagedRuleOverride 2 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicyManagedRuleOverride -RuleId $ruleId is a null-valued parameter value. -RuleId Assign value for $ruleId.
⚠️ New-AzApplicationGatewayFirewallPolicyManagedRuleOverride 3 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicyManagedRuleOverride -RuleId $ruleId is a null-valued parameter value. -RuleId Assign value for $ruleId.
⚠️ New-AzBastionShareableLink 1 1 Unassigned_Variable Get-AzVM -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName.
⚠️ New-AzBastionShareableLink 1 1 Unassigned_Variable Get-AzVM -Name $vmName is a null-valued parameter value. -Name Assign value for $vmName.
⚠️ New-AzBastionShareableLink 1 2 Unassigned_Variable New-AzBastionShareableLink -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName.
⚠️ New-AzBastionShareableLink 1 2 Unassigned_Variable New-AzBastionShareableLink -Name $bastionName is a null-valued parameter value. -Name Assign value for $bastionName.
⚠️ New-AzBastionShareableLink 2 1 Unassigned_Variable Get-AzVM -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName.
⚠️ New-AzBastionShareableLink 2 1 Unassigned_Variable Get-AzVM -Name $vmName1 is a null-valued parameter value. -Name Assign value for $vmName1.
⚠️ New-AzBastionShareableLink 2 2 Unassigned_Variable Get-AzVM -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName.
⚠️ New-AzBastionShareableLink 2 2 Unassigned_Variable Get-AzVM -Name $vmName2 is a null-valued parameter value. -Name Assign value for $vmName2.
⚠️ New-AzBastionShareableLink 2 3 Unassigned_Variable Get-AzBastion -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName.
⚠️ New-AzBastionShareableLink 2 3 Unassigned_Variable Get-AzBastion -Name $bastionName is a null-valued parameter value. -Name Assign value for $bastionName.
⚠️ New-AzBastionShareableLink 2 4 Mismatched_Parameter_Value_Type New-AzBastionShareableLink -TargetVmId $vm1.Id, $vm2.Id is not an expected parameter value type. -TargetVmId Use correct parameter value type. Expected Type is string. Now the type is Microsoft.Azure.Commands.Compute.Models.PSVirtualMachineInstanceView.(Command).
⚠️ New-AzPrivateLinkService 1 4 Mismatched_Parameter_Value_Type New-AzPrivateLinkServiceIpConfig -Subnet $subnet is not an expected parameter value type. -Subnet Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.Network.Models.PSSubnet. Now the type is Microsoft.Azure.Commands.Network.Models.PSVirtualNetwork.(Command).
⚠️ New-AzPrivateLinkService 2 4 Mismatched_Parameter_Value_Type New-AzPrivateLinkServiceIpConfig -Subnet $subnet is not an expected parameter value type. -Subnet Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.Network.Models.PSSubnet. Now the type is Microsoft.Azure.Commands.Network.Models.PSVirtualNetwork.(Command).
⚠️ New-AzPrivateLinkService 2 5 Mismatched_Parameter_Value_Type New-AzPrivateLinkServiceIpConfig -Subnet $subnet is not an expected parameter value type. -Subnet Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.Network.Models.PSSubnet. Now the type is Microsoft.Azure.Commands.Network.Models.PSVirtualNetwork.(Command).
⚠️ New-AzPrivateLinkService 2 6 Mismatched_Parameter_Value_Type New-AzPrivateLinkServiceIpConfig -Subnet $subnet is not an expected parameter value type. -Subnet Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.Network.Models.PSSubnet. Now the type is Microsoft.Azure.Commands.Network.Models.PSVirtualNetwork.(Command).
⚠️ Remove-AzBastionShareableLink 1 1 Unassigned_Variable Remove-AzBastionShareableLink -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName.
⚠️ Remove-AzBastionShareableLink 1 1 Unassigned_Variable Remove-AzBastionShareableLink -Name $bastionName is a null-valued parameter value. -Name Assign value for $bastionName.
⚠️ Remove-AzBastionShareableLink 1 1 Unassigned_Variable Remove-AzBastionShareableLink -TargetVmId $vm.Id is a null-valued parameter value. -TargetVmId Assign value for $vm.Id.
⚠️ Remove-AzBastionShareableLink 2 1 Unassigned_Variable Remove-AzBastionShareableLink -InputObject $bastion is a null-valued parameter value. -InputObject Assign value for $bastion.
⚠️ Remove-AzBastionShareableLink 2 1 Unassigned_Variable Remove-AzBastionShareableLink -TargetVmId $vm.Id is a null-valued parameter value. -TargetVmId Assign value for $vm.Id.
⚠️Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Get-AzBastionShareableLink 1 1 Unassigned_Variable Get-AzBastionShareableLink -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName.
⚠️ Get-AzBastionShareableLink 1 1 Unassigned_Variable Get-AzBastionShareableLink -Name $bastionName is a null-valued parameter value. -Name Assign value for $bastionName.
⚠️ Get-AzBastionShareableLink 2 1 Unassigned_Variable Get-AzBastionShareableLink -InputObject $bastion is a null-valued parameter value. -InputObject Assign value for $bastion.
⚠️ Get-AzBastionShareableLink 2 1 Unassigned_Variable Get-AzBastionShareableLink -TargetVmId $vm1.Id is a null-valued parameter value. -TargetVmId Assign value for $vm1.Id.
⚠️ New-AzApplicationGatewayFirewallPolicyManagedRuleOverride 1 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicyManagedRuleOverride -RuleId $ruleId is a null-valued parameter value. -RuleId Assign value for $ruleId.
⚠️ New-AzApplicationGatewayFirewallPolicyManagedRuleOverride 2 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicyManagedRuleOverride -RuleId $ruleId is a null-valued parameter value. -RuleId Assign value for $ruleId.
⚠️ New-AzApplicationGatewayFirewallPolicyManagedRuleOverride 3 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicyManagedRuleOverride -RuleId $ruleId is a null-valued parameter value. -RuleId Assign value for $ruleId.
⚠️ New-AzBastionShareableLink 1 1 Unassigned_Variable Get-AzVM -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName.
⚠️ New-AzBastionShareableLink 1 1 Unassigned_Variable Get-AzVM -Name $vmName is a null-valued parameter value. -Name Assign value for $vmName.
⚠️ New-AzBastionShareableLink 1 2 Unassigned_Variable New-AzBastionShareableLink -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName.
⚠️ New-AzBastionShareableLink 1 2 Unassigned_Variable New-AzBastionShareableLink -Name $bastionName is a null-valued parameter value. -Name Assign value for $bastionName.
⚠️ New-AzBastionShareableLink 2 1 Unassigned_Variable Get-AzVM -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName.
⚠️ New-AzBastionShareableLink 2 1 Unassigned_Variable Get-AzVM -Name $vmName1 is a null-valued parameter value. -Name Assign value for $vmName1.
⚠️ New-AzBastionShareableLink 2 2 Unassigned_Variable Get-AzVM -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName.
⚠️ New-AzBastionShareableLink 2 2 Unassigned_Variable Get-AzVM -Name $vmName2 is a null-valued parameter value. -Name Assign value for $vmName2.
⚠️ New-AzBastionShareableLink 2 3 Unassigned_Variable Get-AzBastion -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName.
⚠️ New-AzBastionShareableLink 2 3 Unassigned_Variable Get-AzBastion -Name $bastionName is a null-valued parameter value. -Name Assign value for $bastionName.
⚠️ New-AzBastionShareableLink 2 4 Mismatched_Parameter_Value_Type New-AzBastionShareableLink -TargetVmId $vm1.Id, $vm2.Id is not an expected parameter value type. -TargetVmId Use correct parameter value type. Expected Type is string. Now the type is Microsoft.Azure.Commands.Compute.Models.PSVirtualMachineInstanceView.(Command).
⚠️ New-AzPrivateLinkService 1 4 Mismatched_Parameter_Value_Type New-AzPrivateLinkServiceIpConfig -Subnet $subnet is not an expected parameter value type. -Subnet Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.Network.Models.PSSubnet. Now the type is Microsoft.Azure.Commands.Network.Models.PSVirtualNetwork.(Command).
⚠️ New-AzPrivateLinkService 2 4 Mismatched_Parameter_Value_Type New-AzPrivateLinkServiceIpConfig -Subnet $subnet is not an expected parameter value type. -Subnet Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.Network.Models.PSSubnet. Now the type is Microsoft.Azure.Commands.Network.Models.PSVirtualNetwork.(Command).
⚠️ New-AzPrivateLinkService 2 5 Mismatched_Parameter_Value_Type New-AzPrivateLinkServiceIpConfig -Subnet $subnet is not an expected parameter value type. -Subnet Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.Network.Models.PSSubnet. Now the type is Microsoft.Azure.Commands.Network.Models.PSVirtualNetwork.(Command).
⚠️ New-AzPrivateLinkService 2 6 Mismatched_Parameter_Value_Type New-AzPrivateLinkServiceIpConfig -Subnet $subnet is not an expected parameter value type. -Subnet Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.Network.Models.PSSubnet. Now the type is Microsoft.Azure.Commands.Network.Models.PSVirtualNetwork.(Command).
⚠️ Remove-AzBastionShareableLink 1 1 Unassigned_Variable Remove-AzBastionShareableLink -ResourceGroupName $RgName is a null-valued parameter value. -ResourceGroupName Assign value for $RgName.
⚠️ Remove-AzBastionShareableLink 1 1 Unassigned_Variable Remove-AzBastionShareableLink -Name $bastionName is a null-valued parameter value. -Name Assign value for $bastionName.
⚠️ Remove-AzBastionShareableLink 1 1 Unassigned_Variable Remove-AzBastionShareableLink -TargetVmId $vm.Id is a null-valued parameter value. -TargetVmId Assign value for $vm.Id.
⚠️ Remove-AzBastionShareableLink 2 1 Unassigned_Variable Remove-AzBastionShareableLink -InputObject $bastion is a null-valued parameter value. -InputObject Assign value for $bastion.
⚠️ Remove-AzBastionShareableLink 2 1 Unassigned_Variable Remove-AzBastionShareableLink -TargetVmId $vm.Id is a null-valued parameter value. -TargetVmId Assign value for $vm.Id.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.RecoveryServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
️✔️Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Az.Security
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.ServiceBus
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.SignalR
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Az.Websites
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows

@msJinLei msJinLei changed the title Network release Merge release-network-2024-03-01 to main Sep 19, 2024
@msJinLei msJinLei added the Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged. label Sep 19, 2024
Copy link

‼️ Do NOT use squash to merge this pull request. All the commits must be merged to the target branch.
‼️ Enable "Allow merge commits" in the pull request settings. Select "Merge Commits" to merge the PR. Then go back to settings and disable the option.

@msJinLei
Copy link
Contributor Author

[Error]     1. Credential Scanner Error CSCAN-GENERAL0060 - File: SecurityTmp/src/Network/Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.BastionTests/TestBastionShareableLink.json:SecurityTmp/src/Network/Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.BastionTests/TestBastionShareableLink.json. Line: 3030. Column 414. 
    Signature: a62bf73c51a7405a72163080cb54af0b4125927b0697e962a9340220827ff3ee
    Tool: Credential Scanner: Rule: CSCAN-GENERAL0060 (General Password). https://aka.ms/CredScanDocs
    A potential secret was detected. Validate file contains secrets, remove, rotate credential, and use approved store. For additional information on secret remediation see the remediation section at https://aka.ms/CredScanDocs 

@kamboj-prjwl
Copy link
Member

@msJinLei Which branch are you going to merge in the release ? msJinLei:network-release or release-network-2024-03-01

@msJinLei msJinLei marked this pull request as ready for review September 19, 2024 23:36
@msJinLei
Copy link
Contributor Author

msJinLei commented Sep 19, 2024

@msJinLei Which branch are you going to merge in the release ? msJinLei:network-release or release-network-2024-03-01

@kamboj-prjwl
msJinLei:network-release is the branch create branch release-network-2024-03-01 withmain branch merged
You can view the commit list for the details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.