Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate KubernetesRuntime from generation to main #26118

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

azure-pipelines[bot]
Copy link
Contributor

Description

Migrate KubernetesRuntime from generation to main
The last commit of src/KubernetesRuntime in generation is:
commit c508b34 Author: upxinxin [email protected] Date: Wed Sep 18 11:55:37 2024 +0800 [KubernetesRuntime]Onboarding Az.KubernetesRuntime (#25969) * generate from swagger * use pr repo api version * generate and build using 2024-05-01-preview * implement CheckRPRegistration * complete storage class enable/disable * reorg * add examples * add dependency check for disable storage class * update * add guide to create polymorphic models * Add enable/disable and examples for ArcNetworking service * add changelog * fix * add tests for CRUD * remove write-hosts * temp save * Fix playback error * Update swagger path * Update swagger to 2024-03-01 version * Fix naming * update examples for service objects * Add bgp update example * suppress error * rename ResourceUri to ArcConnectedClusterUri * To trigger CI check * Rename ArcConnectedClusterUri to ArcConnectedClusterId * update * update * Update --------- Co-authored-by: Junda Chen [email protected] Co-authored-by: Xinyi Chen [email protected] Co-authored-by: Xinyi Chen [email protected] Co-authored-by: Lei jin [email protected]

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Sep 18, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.KubernetesRuntime
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzKubernetesRuntimeBgpPeer Get-AzKubernetesRuntimeBgpPeer Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzKubernetesRuntimeBgpPeer Get-AzKubernetesRuntimeBgpPeer changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzKubernetesRuntimeLoadBalancer Get-AzKubernetesRuntimeLoadBalancer Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzKubernetesRuntimeLoadBalancer Get-AzKubernetesRuntimeLoadBalancer changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzKubernetesRuntimeService Get-AzKubernetesRuntimeService Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzKubernetesRuntimeService Get-AzKubernetesRuntimeService changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzKubernetesRuntimeStorageClass Get-AzKubernetesRuntimeStorageClass Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzKubernetesRuntimeStorageClass Get-AzKubernetesRuntimeStorageClass changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzKubernetesRuntimeBlobStorageClassTypePropertiesObject New-AzKubernetesRuntimeBlobStorageClassTypePropertiesObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzKubernetesRuntimeNativeStorageClassTypePropertiesObject New-AzKubernetesRuntimeNativeStorageClassTypePropertiesObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzKubernetesRuntimeNfsStorageClassTypePropertiesObject New-AzKubernetesRuntimeNfsStorageClassTypePropertiesObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzKubernetesRuntimeRwxStorageClassTypePropertiesObject New-AzKubernetesRuntimeRwxStorageClassTypePropertiesObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzKubernetesRuntimeSmbStorageClassTypePropertiesObject New-AzKubernetesRuntimeSmbStorageClassTypePropertiesObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzKubernetesRuntimeBgpPeer Get-AzKubernetesRuntimeBgpPeer Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzKubernetesRuntimeBgpPeer Get-AzKubernetesRuntimeBgpPeer changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzKubernetesRuntimeLoadBalancer Get-AzKubernetesRuntimeLoadBalancer Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzKubernetesRuntimeLoadBalancer Get-AzKubernetesRuntimeLoadBalancer changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzKubernetesRuntimeService Get-AzKubernetesRuntimeService Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzKubernetesRuntimeService Get-AzKubernetesRuntimeService changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzKubernetesRuntimeStorageClass Get-AzKubernetesRuntimeStorageClass Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzKubernetesRuntimeStorageClass Get-AzKubernetesRuntimeStorageClass changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzKubernetesRuntimeBlobStorageClassTypePropertiesObject New-AzKubernetesRuntimeBlobStorageClassTypePropertiesObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzKubernetesRuntimeNativeStorageClassTypePropertiesObject New-AzKubernetesRuntimeNativeStorageClassTypePropertiesObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzKubernetesRuntimeNfsStorageClassTypePropertiesObject New-AzKubernetesRuntimeNfsStorageClassTypePropertiesObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzKubernetesRuntimeRwxStorageClassTypePropertiesObject New-AzKubernetesRuntimeRwxStorageClassTypePropertiesObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzKubernetesRuntimeSmbStorageClassTypePropertiesObject New-AzKubernetesRuntimeSmbStorageClassTypePropertiesObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ AssemblyInfo.cs will be updated automatically. Please do not update it manually. Revert AssemblyInfo.cs to its last version.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ AssemblyInfo.cs will be updated automatically. Please do not update it manually. Revert AssemblyInfo.cs to its last version.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 40.00 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 40.00% Test coverage for the module cannot be lower than 50%.
⚠️PowerShell Core - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 40.00% Test coverage for the module cannot be lower than 50%.
⚠️Windows PowerShell - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 40.00% Test coverage for the module cannot be lower than 50%.

Copy link
Contributor

Thank you for your contribution azure-pipelines[bot]! We will review the pull request and get back to you soon.

@msJinLei msJinLei merged commit 0871f0a into main Sep 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants