[DataFactory]Support New Features In ADF #26070
Conversation
️✔️Az.Accounts
️✔️Az.DataFactory
|
...ataFactory/DataFactory.Management.Sdk/Generated/Models/MariaDBLinkedServiceTypeProperties.cs
Show resolved
Hide resolved
...ataFactory/DataFactory.Management.Sdk/Generated/Models/MariaDBLinkedServiceTypeProperties.cs
Show resolved
Hide resolved
| @@ -18,6 +18,8 @@ | |||
| - Additional information about change #1 | |||
| --> | |||
| ## Upcoming Release | |||
| * Added support for Iceberg format as a sink. | |||
There was a problem hiding this comment.
Do you have the help document update?
There was a problem hiding this comment.
No, ADF only update sdk for powershell, nothing change in cmd
There was a problem hiding this comment.
No, ADF only update sdk for powershell, nothing change in cmd
@Jingshu918 Please confirm you module is not going to release a new version after the merge is merged
There was a problem hiding this comment.
I don't know what you mean "module is not going to release a new version", After the PR merged Powershell should release a new version for DataFactory, for such change we have released many years.
#25825
https://www.powershellgallery.com/packages/Az.DataFactory/1.18.7
There was a problem hiding this comment.
@Jingshu918 Sorry, please ignore the previous comment. I may comment in the wrong PR.
The review comments for you PR is
Please refer to https://github.com/Azure/azure-powershell/blob/main/documentation/development-docs/help-generation.md to update your help doc of your module
There was a problem hiding this comment.
We are not updating our modules, so we need not do that.
There was a problem hiding this comment.
We are not updating our modules, so we need not do that.
The help doc should be consistent with the source codes and currently the cmdlet help docs are already out of date.
There was a problem hiding this comment.
I don't think it is out of data in DataFactory. DataFactory maybe a special Service from others.
For example, we only change the definitionFile which customers can know from other places and it did not need customer change the modules and docs.
Set-AzDataFactoryV2Dataset
[-Name]
[-DefinitionFile]
[-ResourceGroupName]
[-DataFactoryName]
[-Force]
[-DefaultProfile ]
[-WhatIf]
[-Confirm]
[]
msJinLei
added
the
needs-author-feedback
msJinLei
added
needs-author-feedback
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
There was a problem hiding this comment.
@Jingshu918 The help doc of DataFactory is out of date. Could you check https://github.com/Azure/azure-powershell/blob/main/src/DataFactory/DataFactory/help/Az.DataFactory.md?
|
@msJinLei Sorry, I did not know what you mean "out of date", do we have similar change for that? |
@Jingshu918 To update help doc is part of the development process of Azure-PowerShell. We usually ask the partners to update the help docs of their modules in their PRs even the docs changes are not caused by their PR merely. Are you the module owner of data factory? If not, could you provide the owner of |
msJinLei
added
the
needs-author-feedback
microsoft-github-policy-service
bot
added
needs-team-attention
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.