Binder models tcgc #2759

joheredi · 2024-08-19T18:33:08Z

No description provided.

qiaozha · 2024-08-20T09:19:01Z

packages/typespec-ts/src/index.ts

@@ -248,8 +249,8 @@ export async function $onEmit(context: EmitContext) {

    const isMultiClients = modularCodeModel.clients.length > 1;

+    emitTypes(dpgContext.sdkPackage, { sourceRoot: modularSourcesRoot });


feel like this change is moving the models outside of the subclients folder already? #2556 should I still wait for this pr to be merged ?

qiaozha · 2024-09-03T07:25:35Z

...spec-test/test/NetworkAnalytics.Management/generated/typespec-ts/src/api/operations/index.ts

 import { NetworkAnalyticsContext as Client } from "../index.js";
 import {
  StreamableMethod,
  operationOptionsToRequestParameters,
  PathUncheckedResponse,
  createRestError,
 } from "@azure-rest/core-client";
+import {
+  _DataProductListResult,


need to check why we didn't remove those unused imports?

...es/typespec-test/test/NetworkAnalytics.Management/generated/typespec-ts/src/models/models.ts

packages/typespec-ts/src/modular/emit-models.ts

...s/typespec-test/test/anomalyDetector/generated/typespec-ts/review/ai-anomaly-detector.api.md

...st/test/NetworkAnalytics.Management/generated/typespec-ts/review/arm-networkanalytics.api.md

qiaozha · 2024-09-05T02:14:00Z

...ec-test/test/NetworkAnalytics.Management/generated/typespec-ts/src/api/dataProducts/index.ts

  AccountSas,
  AccountSasToken,
  KeyVaultInfo,
  RoleAssignmentCommonProperties,
  RoleAssignmentDetail,
  ListRoleAssignments,
  _DataProductListResult,
+  _DataTypeListResult,
+  _DataProductsCatalogListResult,
+  _OperationListResult,


still need to investigate why this is imported however not being used.

packages/typespec-ts/src/index.ts

...st/test/NetworkAnalytics.Management/generated/typespec-ts/review/arm-networkanalytics.api.md

packages/typespec-test/test/eventgrid_modular/generated/typespec-ts/src/api/eventGridContext.ts

qiaozha · 2024-09-05T13:21:37Z

...pespec-test/test/contentsafety_modular/generated/typespec-ts/review/ai-content-safety.api.md

@@ -5,6 +5,7 @@
 ```ts

 import { ClientOptions } from '@azure-rest/core-client';
+import { ErrorModel } from '@azure-rest/core-client';


should also import ErrorModel from binder

...pespec-test/test/contentsafety_modular/generated/typespec-ts/src/api/contentSafetyContext.ts

...pespec-test/test/contentsafety_modular/generated/typespec-ts/review/ai-content-safety.api.md

...ec-test/test/NetworkAnalytics.Management/generated/typespec-ts/src/api/dataProducts/index.ts

...st/test/NetworkAnalytics.Management/generated/typespec-ts/src/api/networkAnalyticsContext.ts

...es/typespec-test/test/NetworkAnalytics.Management/generated/typespec-ts/src/models/models.ts

...s/typespec-test/test/anomalyDetector/generated/typespec-ts/review/ai-anomaly-detector.api.md

packages/typespec-test/test/loadtesting_modular/generated/typespec-ts/src/index.ts

packages/typespec-test/test/openai_generic/generated/typespec-ts/src/models/models.ts

packages/typespec-test/test/openai_modular/generated/typespec-ts/review/openai_modular.api.md

packages/typespec-test/test/eventgrid_modular/generated/typespec-ts/src/api/operations.ts

joheredi added 2 commits August 15, 2024 16:16

Generate models from TCGC and use binder

10267e1

generic serializers

1d0e542

qiaozha reviewed Aug 20, 2024

View reviewed changes

qiaozha self-assigned this Aug 28, 2024

qiaozha added 4 commits August 29, 2024 15:09

fix const and enum value expression

5522764

merge main and resolve conflicts

ff42613

merge main

fb5cc9f

fix paged result model name

136a66b

qiaozha reviewed Sep 3, 2024

View reviewed changes

qiaozha and others added 4 commits September 3, 2024 15:34

Update packages/typespec-ts/src/modular/emit-models.ts

1205b52

remove old imports and refactor serializer util

e9446b3

fix serializer

efe343b

fix anomalydetector

1f251c3

qiaozha reviewed Sep 4, 2024

View reviewed changes

...s/typespec-test/test/anomalyDetector/generated/typespec-ts/review/ai-anomaly-detector.api.md Outdated Show resolved Hide resolved

fix readonly, enum docs missing, serializeRecord crash issues

e8ffadb

qiaozha reviewed Sep 5, 2024

View reviewed changes

...st/test/NetworkAnalytics.Management/generated/typespec-ts/review/arm-networkanalytics.api.md Show resolved Hide resolved

qiaozha reviewed Sep 5, 2024

View reviewed changes

...st/test/NetworkAnalytics.Management/generated/typespec-ts/review/arm-networkanalytics.api.md Outdated Show resolved Hide resolved

qiaozha reviewed Sep 5, 2024

View reviewed changes

qiaozha and others added 6 commits September 5, 2024 10:21

Update packages/typespec-ts/src/index.ts

6a7e682

Merge branch 'main' into binder-models-tcgc

cb143cc

fix extensible enum docs, knownvalue enum

be80522

fix known enum name

91e4e9e

Merge branch 'main' into binder-models-tcgc

c61258e

use binder to resolve dependencies and reserve work

92c5a25

qiaozha reviewed Sep 5, 2024

View reviewed changes

...st/test/NetworkAnalytics.Management/generated/typespec-ts/review/arm-networkanalytics.api.md Outdated Show resolved Hide resolved

qiaozha reviewed Sep 5, 2024

View reviewed changes

joheredi added 2 commits September 5, 2024 15:22

Fix missing TokenCredential imports

5149443

Fix client not found issue

53e235f

joheredi force-pushed the binder-models-tcgc branch from 92c5a25 to 1d0e542 Compare September 5, 2024 22:57

fix client factory signature

a6384c7

qiaozha added 8 commits September 10, 2024 20:53

fix duplicate imports

45cdf02

fix record serializer missing

c203010

fix unused imports

b1532c1

update serializer and reserve work

02abce0

fix body optional

2b30bb3

use tcgc name

4d799fc

fix model namespace name

849dbae

smoke-test

e673ece

qiaozha reviewed Sep 11, 2024

View reviewed changes

qiaozha added 5 commits September 12, 2024 10:20

fix extra quotes

7794efc

fix serializer and deserializer missing

4c43a3a

normalize clientOptional params

2aac9f4

add array serializer

4629802

add array serializer

0f092a8

qiaozha reviewed Sep 12, 2024

View reviewed changes

packages/typespec-test/test/eventgrid_modular/generated/typespec-ts/src/api/operations.ts Outdated Show resolved Hide resolved

qiaozha added 15 commits September 12, 2024 22:57

refactor operation helpers

1aac384

fix serialize value

8a10a46

fix smoke test

14e3118

use binder for streamable and generate empty object as record of any

aa62957

fix docs missing

5132824

modular models for multi clients

cd3fe73

use modular client name as context name

5fb0ae6

move options into api folder

66dd336

fix docs missing

3046174

fix unit test

9c8d698

fix some unit test and deserializer missing

04f7ab5

refactor serializer in operationHelpers

7022f13

fix some ut and add alias description

f4afc39

fix some ut description

d1306cc

fix duplicate union type generation

b804c19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Binder models tcgc #2759

Binder models tcgc #2759

joheredi commented Aug 19, 2024

qiaozha Aug 20, 2024

qiaozha Sep 3, 2024

qiaozha Sep 5, 2024

qiaozha Sep 5, 2024

		@@ -248,8 +249,8 @@ export async function $onEmit(context: EmitContext) {

		const isMultiClients = modularCodeModel.clients.length > 1;

		emitTypes(dpgContext.sdkPackage, { sourceRoot: modularSourcesRoot });

Binder models tcgc #2759

Are you sure you want to change the base?

Binder models tcgc #2759

Conversation

joheredi commented Aug 19, 2024

qiaozha Aug 20, 2024

Choose a reason for hiding this comment

qiaozha Sep 3, 2024

Choose a reason for hiding this comment

qiaozha Sep 5, 2024

Choose a reason for hiding this comment

qiaozha Sep 5, 2024

Choose a reason for hiding this comment