Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't propagate client parameter #5044

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

chunyu3
Copy link
Member

@chunyu3 chunyu3 commented Sep 4, 2024

Description

Sync microsoft/typespec#4295
Fix #4810

We will not propagate client parameters (such as endpoint, or the parameter in the uri) to each operation, so

  • When create client fields we need to merge the client parameters with the parameters in each operation whose kind is Client (means the operation parameter is bumped to client level).
  • When generate operation method, merge client parameters with operation parameters, we need client parameters to construe uri.

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@chunyu3 chunyu3 changed the title don't propagte client parameter don't propagate client parameter Sep 5, 2024
@chunyu3
Copy link
Member Author

chunyu3 commented Sep 6, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

emit client parameters in InputClient.Parameters, not progagate those parameters to each operatio
1 participant