Reduce allocations/cpu from scraping #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a followup to the prior streaming collection PR where we reduce the CPU and allocations incurred during scraping. benchmark old ns/op new ns/op delta BenchmarkIterator_TimeSeries-10 365 119 -67.39% benchmark old allocs new allocs delta BenchmarkIterator_TimeSeries-10 9 0 -100.00% benchmark old bytes new bytes delta BenchmarkIterator_TimeSeries-10 480 0 -100.00%
jessejlt
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to the prior streaming collection PR where we reduce the CPU and allocations incurred during scraping.
benchmark old ns/op new ns/op delta
BenchmarkIterator_TimeSeries-10 365 119 -67.39%
benchmark old allocs new allocs delta
BenchmarkIterator_TimeSeries-10 9 0 -100.00%
benchmark old bytes new bytes delta
BenchmarkIterator_TimeSeries-10 480 0 -100.00%