"Update UpdateEntity and DeleteEntity to throw InvalidInput error for Malformed Etag" #2062

PrasantJillella · 2023-07-21T08:10:01Z

No description provided.

…rmed Etag"

blueww

Please see my comments to fix the build failure.
Please add change log: https://github.com/Azure/Azurite/blob/main/ChangeLog.md

src/table/handlers/TableHandler.ts

blueww · 2023-07-21T10:07:18Z

The test case build fail:

tests/table/apis/table.entity.issues.test.ts(220,11): error TS1155: 'const' declarations must be initialized.
tests/table/apis/table.entity.issues.test.ts(232,17): error TS2554: Expected 2-3 arguments, but got 1.
tests/table/apis/table.entity.issues.test.ts(234,15): error TS2454: Variable 'rowKey' is used before being assigned.
tests/table/apis/table.entity.issues.test.ts(244,15): error TS2454: Variable 'rowKey' is used before being assigned.
tests/table/apis/table.entity.issues.test.ts(252,17): error TS2551: Property 'mergeEntity' does not exist on type 'TableClient'. Did you mean 'getEntity'?
tests/table/apis/table.entity.issues.test.ts(254,15): error TS2454: Variable 'rowKey' is used before being assigned.
tests/table/apis/table.entity.issues.test.ts(256,15): error TS7006: Parameter 'reason' implicitly has an 'any' type.

tests/table/apis/table.entity.issues.test.ts

PrasantJillella

Addressing comments.

tests/table/apis/table.entity.issues.test.ts

blueww

The code change looks good to me.
Would you please also add the change to changelog: https://github.com/Azure/Azurite/blob/main/ChangeLog.md

PrasantJillella · 2023-08-11T09:45:54Z

The code change looks good to me. Would you please also add the change to changelog: https://github.com/Azure/Azurite/blob/main/ChangeLog.md

Hi raised a PR for the suggested changeLog updated
#2095

Please take a look, thank you.

blueww · 2023-08-14T03:04:46Z

@PrasantJillella

The change log looks good to me. But why not add it into same PR as the code change？
For better tracking the code change in the future, normally we should have change log in same PR with the code change.

blueww · 2023-08-14T03:05:02Z

/azp run

azure-pipelines · 2023-08-14T03:05:16Z

Azure Pipelines successfully started running 1 pipeline(s).

…rmed Etag"

…urite into MalformedEtag

blueww · 2023-08-16T08:49:08Z

@PrasantJillella

Please note, there still 2 things blocked the PR from merge:

the license/cla is still not agreed by you.
the change log is not added to same PR with code change.

…rmed Etag"

Add missing requestId to the appendBlock operation of an append blob. Fixes Azure#631.

Bumps [tslib](https://github.com/Microsoft/tslib) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/Microsoft/tslib/releases) - [Commits](microsoft/tslib@2.6.0...v2.6.1) --- updated-dependencies: - dependency-name: tslib dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…osecond precision is provided in the underlying value. (Azure#2077) * fix: Resolve issues with datetime comparisons in scenarios where microsecond precision is provided in the underlying value. Fixes Filtering by Dates with Table Service no longer working in 3.25.0 Azure#2069 * doc: Update changelog * fix: Ensure that we only match exact GUIDs for the legacy comparison model

…thing (Azure#2079) * Adding all of the code to correctly remove any entities with non populated fields when doing a query on said field. This includes the tests, as well as a reproduction for the current issue * The current check for partition key was using !! which for an empty string in JS resolve to false, causing the query context to think this was a table instead of an entity. Instead check for the existence of the field * Adding to the changelog * Addressing PR comment and removing unecessary !! symbols --------- Co-authored-by: Garrett Baski <[email protected]> Co-authored-by: Wei Wei <[email protected]>

Bumps [@azure/core-auth](https://github.com/Azure/azure-sdk-for-js) from 1.4.0 to 1.5.0. - [Release notes](https://github.com/Azure/azure-sdk-for-js/releases) - [Changelog](https://github.com/Azure/azure-sdk-for-js/blob/main/documentation/Changelog-for-next-generation.md) - [Commits](https://github.com/Azure/azure-sdk-for-js/compare/@azure/core-auth_1.4.0...@azure/core-auth_1.5.0) --- updated-dependencies: - dependency-name: "@azure/core-auth" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@azure/core-rest-pipeline](https://github.com/Azure/azure-sdk-for-js) from 1.11.0 to 1.12.0. - [Release notes](https://github.com/Azure/azure-sdk-for-js/releases) - [Changelog](https://github.com/Azure/azure-sdk-for-js/blob/main/documentation/Changelog-for-next-generation.md) - [Commits](https://github.com/Azure/azure-sdk-for-js/compare/@azure/core-rest-pipeline_1.11.0...@azure/core-rest-pipeline_1.12.0) --- updated-dependencies: - dependency-name: "@azure/core-rest-pipeline" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [cross-env](https://github.com/kentcdodds/cross-env) from 6.0.3 to 7.0.3. - [Release notes](https://github.com/kentcdodds/cross-env/releases) - [Changelog](https://github.com/kentcdodds/cross-env/blob/master/CHANGELOG.md) - [Commits](kentcdodds/cross-env@v6.0.3...v7.0.3) --- updated-dependencies: - dependency-name: cross-env dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@types/validator](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/validator) from 13.7.17 to 13.11.1. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/validator) --- updated-dependencies: - dependency-name: "@types/validator" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [jsonwebtoken](https://github.com/auth0/node-jsonwebtoken) and [@types/jsonwebtoken](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jsonwebtoken). These dependencies needed to be updated together. Updates `jsonwebtoken` from 9.0.0 to 9.0.1 - [Changelog](https://github.com/auth0/node-jsonwebtoken/blob/master/CHANGELOG.md) - [Commits](auth0/node-jsonwebtoken@v9.0.0...v9.0.1) Updates `@types/jsonwebtoken` from 9.0.1 to 9.0.2 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jsonwebtoken) --- updated-dependencies: - dependency-name: jsonwebtoken dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: "@types/jsonwebtoken" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [prettier](https://github.com/prettier/prettier) from 3.0.0 to 3.0.1. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.0.0...3.0.1) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [mysql2](https://github.com/sidorares/node-mysql2) from 3.5.2 to 3.6.0. - [Release notes](https://github.com/sidorares/node-mysql2/releases) - [Changelog](https://github.com/sidorares/node-mysql2/blob/master/Changelog.md) - [Commits](sidorares/node-mysql2@v3.5.2...v3.6.0) --- updated-dependencies: - dependency-name: mysql2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@types/bluebird](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/bluebird) from 3.5.37 to 3.5.38. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/bluebird) --- updated-dependencies: - dependency-name: "@types/bluebird" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@types/vscode](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/vscode) from 1.80.0 to 1.81.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/vscode) --- updated-dependencies: - dependency-name: "@types/vscode" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [rcedit](https://github.com/electron/node-rcedit) from 3.0.1 to 3.1.0. - [Release notes](https://github.com/electron/node-rcedit/releases) - [Changelog](https://github.com/electron/node-rcedit/blob/master/.releaserc.json) - [Commits](electron/node-rcedit@v3.0.1...v3.1.0) --- updated-dependencies: - dependency-name: rcedit dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix 2061 & 2083 * fix issue Azure#2064 * Add test cases and change log --------- Co-authored-by: EmmaZhu <[email protected]>

…iroment varialbe (Azure#2029)

Bumps [prettier](https://github.com/prettier/prettier) from 3.0.1 to 3.0.2. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.0.1...3.0.2) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [eslint](https://github.com/eslint/eslint) from 8.46.0 to 8.47.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.46.0...v8.47.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [lint-staged](https://github.com/okonet/lint-staged) from 13.2.3 to 14.0.0. - [Release notes](https://github.com/okonet/lint-staged/releases) - [Commits](lint-staged/lint-staged@v13.2.3...v14.0.0) --- updated-dependencies: - dependency-name: lint-staged dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [azure-storage](https://github.com/Azure/azure-storage-node) from 2.10.6 to 2.10.7. - [Release notes](https://github.com/Azure/azure-storage-node/releases) - [Changelog](https://github.com/Azure/azure-storage-node/blob/master/ChangeLog.md) - [Commits](https://github.com/Azure/azure-storage-node/commits) --- updated-dependencies: - dependency-name: azure-storage dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…urite into MalformedEtag

blueww · 2023-08-18T09:39:13Z

ChangeLog.md

@@ -20,6 +20,9 @@ Queue:
 - Fixed error code when dequeue message with invalid visibilitytimeout (issue #2083)
 - Fixed error code when sas request authentication failed (issue #2064)

+Table:
+- Fixed the errorCode returned, when malformed Etag is provided for table Update/Delete calls. (issue #2013)
+


Add the change log to "## Upcoming Release" above.

"Update, Delete and Merge entities throw InvalidInput error for Malfo…

5491eca

…rmed Etag"

blueww requested changes Jul 21, 2023

View reviewed changes

src/table/handlers/TableHandler.ts Outdated Show resolved Hide resolved

Address comments

2816f13

blueww reviewed Jul 21, 2023

View reviewed changes

tests/table/apis/table.entity.issues.test.ts Outdated Show resolved Hide resolved

blueww reviewed Jul 21, 2023

View reviewed changes

tests/table/apis/table.entity.issues.test.ts Outdated Show resolved Hide resolved

PrasantJillella commented Jul 24, 2023

View reviewed changes

PrasantJillella added 3 commits July 24, 2023 00:13

Address comments

01f3b77

Minor correction

324e0b3

Fix build failure

a6c1e6d

blueww reviewed Aug 4, 2023

View reviewed changes

tests/table/apis/table.entity.issues.test.ts Outdated Show resolved Hide resolved

Moving new tests to bottom of file

5fd3ef1

blueww approved these changes Aug 7, 2023

View reviewed changes

blueww requested changes Aug 7, 2023

View reviewed changes

PrasantJillella added 7 commits August 14, 2023 08:12

"Update, Delete and Merge entities throw InvalidInput error for Malfo…

82ce53a

…rmed Etag"

Address comments

ecd18fa

Address comments

90c82a8

Minor correction

e0cb15e

Fix build failure

a6a3d72

Moving new tests to bottom of file

adb0945

Merge branch 'MalformedEtag' of https://github.com/PrasantJillella/Az…

62b030c

…urite into MalformedEtag

PrasantJillella added 4 commits August 18, 2023 07:21

"Update, Delete and Merge entities throw InvalidInput error for Malfo…

a387b45

…rmed Etag"

Address comments

d3858c8

Address comments

5a540d3

Minor correction

2c981f7

jetuk and others added 24 commits August 18, 2023 09:26

Add requestId to appendBlock (Azure#2074)

b22f623

Add missing requestId to the appendBlock operation of an append blob. Fixes Azure#631.

Bump version for hot fix (Azure#2085)

a38a06d

Fix issue Azure#2061, Azure#2064, Azure#2083 (Azure#2087)

1fab24d

* Fix 2061 & 2083 * fix issue Azure#2064 * Add test cases and change log --------- Co-authored-by: EmmaZhu <[email protected]>

Updated examples of setting Customized Storage Accounts & Keys in env…

1fb1da2

…iroment varialbe (Azure#2029)

Bump service version to 2023-08-03 (Azure#2111)

843b56d

Fetch latest from main and updated changeLog file accordingly

ec55e25

Merge branch 'MalformedEtag' of https://github.com/PrasantJillella/Az…

04ff482

…urite into MalformedEtag

PrasantJillella mentioned this pull request Aug 18, 2023

Change to make Update and Delete entities throw InvalidInput error for Malformed Etag #2122

Open

blueww reviewed Aug 18, 2023

View reviewed changes

"Move change to Upcoming release header"

d1ee678

PrasantJillella changed the title ~~"Update, Delete and Merge entities throw InvalidInput error for Malformed Etag"~~ "Update UpdateEntity and DeleteEntity to throw InvalidInput error for Malformed Etag" Aug 18, 2023

blueww approved these changes Aug 21, 2023

View reviewed changes

blueww merged commit fb3e85a into Azure:main Aug 21, 2023
35 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

"Update UpdateEntity and DeleteEntity to throw InvalidInput error for Malformed Etag" #2062

"Update UpdateEntity and DeleteEntity to throw InvalidInput error for Malformed Etag" #2062

PrasantJillella commented Jul 21, 2023

blueww left a comment

blueww commented Jul 21, 2023

PrasantJillella left a comment

blueww left a comment •

edited

Loading

PrasantJillella commented Aug 11, 2023

blueww commented Aug 14, 2023

blueww commented Aug 14, 2023

azure-pipelines bot commented Aug 14, 2023

blueww commented Aug 16, 2023 •

edited

Loading

blueww Aug 18, 2023

PrasantJillella Aug 18, 2023

PrasantJillella Aug 18, 2023

"Update UpdateEntity and DeleteEntity to throw InvalidInput error for Malformed Etag" #2062

"Update UpdateEntity and DeleteEntity to throw InvalidInput error for Malformed Etag" #2062

Conversation

PrasantJillella commented Jul 21, 2023

blueww left a comment

Choose a reason for hiding this comment

blueww commented Jul 21, 2023

PrasantJillella left a comment

Choose a reason for hiding this comment

blueww left a comment • edited Loading

Choose a reason for hiding this comment

PrasantJillella commented Aug 11, 2023

blueww commented Aug 14, 2023

blueww commented Aug 14, 2023

azure-pipelines bot commented Aug 14, 2023

blueww commented Aug 16, 2023 • edited Loading

blueww Aug 18, 2023

Choose a reason for hiding this comment

PrasantJillella Aug 18, 2023

Choose a reason for hiding this comment

PrasantJillella Aug 18, 2023

Choose a reason for hiding this comment

blueww left a comment •

edited

Loading

blueww commented Aug 16, 2023 •

edited

Loading